Skip to content
This repository was archived by the owner on Aug 4, 2020. It is now read-only.
This repository was archived by the owner on Aug 4, 2020. It is now read-only.

Coverage checking does not check target hosts #15

Open

Description

@jsha

If a test URL is included in a ruleset, but that test URL is not covered by any target host, the checker will not flag an error. See, for instance, EFForg/https-everywhere#1188.

getCoverageProblems should check test URLs against target hosts and flag such problems.

Activity

  1. krngrvr09 commented on Apr 10, 2015

    @krngrvr09

    Hi @jsha, I was able to reproduce this problem. Can we use a library tldextract to check test URLs against target hosts. We can ignore the subdomains and suffixes, and just consider the domain. What do you think?

    Here is the sample code:

    >>> tldextract.extract('http://www.iiitd.edu.in')
    ExtractResult(subdomain='www', domain='iiitd', suffix='edu.in')
    
  2. jsha commented on Apr 10, 2015

    @jsha
    ContributorAuthor

    Hi Karan,

    According to #13, there is already an implementation of the needed code in RuleTrie, but I accidentally bypassed it in #4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions