Repository navigation
ci: give Test (runtime) 15 minutes - #7627
Merged
Merged
Conversation
Core plus engine tests now take 8-10 minutes, so the 10 minute limit cancels runs that are about to pass and dequeues their PRs from the merge queue as failed checks. Match Test (studio)'s 15 minute limit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
![heygengenesis[bot]](https://avatars.githubusercontent.com/in/2913576?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 0 nits · head 3a1d9c8
Checked the timing claims against the runs. In merge-group run 43320080170, the core+engine test step finished green at 22:37:49, and the job was cancelled at its 10:00 limit at 22:37:53. On this head, Test (runtime) took 9m38s. 15 min matches Test (studio). The Test aggregator (3 min timeout) waits on its needs before it starts, so the change doesn't affect it, and no script pins this job's timeout.
3 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Raises the
Test (runtime)job limit from 10 to 15 minutes, the same asTest (studio). Core plus engine tests now take 8 to 10 minutes, so the 10 minute limit cancels runs that are about to pass and dequeues their PRs.Why
The job is under the required
Testcontext, so each cancel takes the PR out of the merge queue as failed checks. On 2026-11-12:Related work
None. Splitting core and engine into two jobs would also cut wall time, and is a possible follow-up.
How
One line in
.github/workflows/ci.yml, plus a comment saying why.Test plan
This PR's own CI runs the job with the new limit.
Claude Opus 5.5
Timing evidence
The test step (
bun run --filter '@hyperframes/{core,engine}' test) takes about 510s of the job. Checkout takes about 21s and workspace setup about 61s. Sampled main push durations over the last day ranged from 417s to 598s, so the job is already close to the limit on most runs, not just slow ones.🤖 Generated with Claude Code