Skip to content

fix(cli): publish keeps Library files out for projects on cloud drives - #7582

Merged
jrusso1020 merged 2 commits into
mainfrom
fix/publish-icloud-library-check
Nov 12, 2026
Merged

jrusso1020 merged 2 commits into
mainfrom
fix/publish-icloud-library-check

Conversation

@jrusso1020

@jrusso1020 jrusso1020 commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

What

publish and cloud render now leave out files in the home Library folder for a project that sits on iCloud Drive (~/Library/Mobile Documents/…) or a File Provider cloud folder (~/Library/CloudStorage/…: Dropbox, OneDrive, Google Drive), with the usual warning. A file in ~/Library/CloudStorage referenced from elsewhere is now copied like an iCloud Drive file instead of being left out. Follow-up to #7577.

Why

#7577 skips the Library check when the project itself sits in ~/Library, so a project in an app's folder can still use its siblings. iCloud Drive lives under ~/Library too, so a project there skipped the check entirely, and a reference such as ~/Library/Application Support/app/token.json was still uploaded with no warning.

Related work

Follows #7577.

How

inHomeAppData now compares the project's own home app-data folder, with the same cloud-drive exceptions (Mobile Documents, CloudStorage), instead of asking whether the project is anywhere under Library. A project on iCloud Drive therefore counts as outside Library. A project elsewhere in ~/Library keeps its siblings as before.

Test plan

  • Unit tests added/updated: a project on iCloud Drive referencing a Library/Application Support file gets no _ext/ copy and one warning. The test fails on main. A CloudStorage test covers both directions and fails without the new exception. The existing AppData/Library/iCloud tests pass (106 passed).
  • Lint, format, typecheck and comment hooks pass
  • Manual testing performed: not applicable (path rule only, covered by the tests)
  • Documentation updated: not applicable
  • Comments follow CONTRIBUTING.md "Comments"

— Rames Jusso

🤖 Generated with Claude Code

jrusso1020 and others added 2 commits November 12, 2026 02:27
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…hen publishing

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jrusso1020 jrusso1020 changed the title fix(cli): publish keeps Library files out for projects on iCloud Drive fix(cli): publish keeps Library files out for projects on cloud drives Nov 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Edit accuracy: accurate 267 (base branch 267), smooth 110 of those

The gate passes.
Smoothness is reported in the artifact, not gated. A case fails only if it fails 2 of 3 runs.

Quarantined, measured but not gated (8)

@heygengenesis heygengenesis Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at 37d2ef8. homeAppDataFolder(projectDir) !== folder treats a project on a cloud drive as outside ~/Library. CloudStorage now joins Mobile Documents as a cloud-drive exception, so Dropbox, OneDrive and Google Drive work both ways: a project there can't pull Library/Application Support, and a project outside can still use assets stored there. A project elsewhere in ~/Library keeps its siblings as before. Both new tests cover the change, and every Actions run on this head passed. (The three cancelled runs were superseded duplicates; their reruns passed.)

@jrusso1020
jrusso1020 added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit f7bf5f0 Nov 12, 2026
88 of 89 checks passed
@jrusso1020
jrusso1020 deleted the fix/publish-icloud-library-check branch November 12, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant