Repository navigation
fix(cli): publish keeps Library files out for projects on cloud drives - #7582
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…hen publishing Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Contributor
There was a problem hiding this comment.
Approving at 37d2ef8. homeAppDataFolder(projectDir) !== folder treats a project on a cloud drive as outside ~/Library. CloudStorage now joins Mobile Documents as a cloud-drive exception, so Dropbox, OneDrive and Google Drive work both ways: a project there can't pull Library/Application Support, and a project outside can still use assets stored there. A project elsewhere in ~/Library keeps its siblings as before. Both new tests cover the change, and every Actions run on this head passed. (The three cancelled runs were superseded duplicates; their reruns passed.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
publishandcloud rendernow leave out files in the homeLibraryfolder for a project that sits on iCloud Drive (~/Library/Mobile Documents/…) or a File Provider cloud folder (~/Library/CloudStorage/…: Dropbox, OneDrive, Google Drive), with the usual warning. A file in~/Library/CloudStoragereferenced from elsewhere is now copied like an iCloud Drive file instead of being left out. Follow-up to #7577.Why
#7577 skips the
Librarycheck when the project itself sits in~/Library, so a project in an app's folder can still use its siblings. iCloud Drive lives under~/Librarytoo, so a project there skipped the check entirely, and a reference such as~/Library/Application Support/app/token.jsonwas still uploaded with no warning.Related work
Follows #7577.
How
inHomeAppDatanow compares the project's own home app-data folder, with the same cloud-drive exceptions (Mobile Documents,CloudStorage), instead of asking whether the project is anywhere underLibrary. A project on iCloud Drive therefore counts as outsideLibrary. A project elsewhere in~/Librarykeeps its siblings as before.Test plan
Library/Application Supportfile gets no_ext/copy and one warning. The test fails onmain. ACloudStoragetest covers both directions and fails without the new exception. The existing AppData/Library/iCloud tests pass (106 passed).— Rames Jusso
🤖 Generated with Claude Code