Repository navigation
docs(studio-app): say brand kits are shared within the workspace only - #7570
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
There was a problem hiding this comment.
Checked the new text against the Studio app (hyperframes-internal studio-app/src/brandKits) and the kit list it reads (EF cutroom/backends/brand_reads.py, GET /v1/brands). No blocker from me.
Accurate
- Yours =
owned, which isrow.space_id == space_id. So every kit in the workspace shows there for every member, whoever made it. - The Studio app has no way to share a kit. The only share-related code is the read-only Shared with you section.
- Kits made on app.heygen.com don't show. The list only takes kits that have a
brand_profileshead row, and only Studio'screate_kitwrites one (_candidate_kitswith_head). That matches your two-account test.
Optional (non-blocking)
- The app still shows a Shared with you section (
KitLibrary.tsx:133, and "Shared with you, view only" in the project picker). It lists HeyGen's preset kits and any Studio-made kit shared into the workspace throughshared_resources. After this change the page never mentions that section, so a user who sees it gets no explanation. You could add a sentence such as: "Kits HeyGen provides appear under Shared with you. You can use them but not change them." Fine to leave it for a follow-up.
I'll approve once Rames has looked and found no blocker.
|
Thanks. Leaving the optional sentence out on purpose: HeyGen's preset kits don't appear under Shared with you in the app either, so that sentence wouldn't be accurate. The section only fills in a case we're not documenting while sharing is low priority. It can get its own line if that changes. |
jrusso1020
left a comment
There was a problem hiding this comment.
Reviewed at 83e2e1aa3fe0b9155b69e30dfaca67258fe28850.
No blocker found. The revised section matches the current workspace-scoped kit list and its Yours grouping. Studio's kit actions do not offer external sharing; ordinary kits created on app.heygen.com lack the Studio profile required by this list. The page already states its sign-in and workspace-feature prerequisites, so it does not promise availability before those gates.
Read the full page and traced the list, grouping and available kit actions in the current Studio implementation. No references to the removed #shared-kits anchor were found in docs. No runtime tests or live account walk were run for this text-only change. The existing review's optional explanation of Shared with you can remain a follow-up.
Need: yes, remove misleading sharing guidance · Size: ok · Reuse: existing workspace visibility terminology · Simpler: direct wording · Structure: fine (checked adjacent page sections; no split)
Risk: low — documentation only.
Verdict: COMMENT — no blockers
Reasoning: The wording describes current workspace behavior without promising an external sharing feature.
— Rames
What
Replaces the "Shared kits" section of the Studio app's brand kits page (
docs/studio-app/brand-kits.mdx) with "Kits and your team":The last sentence (only a workspace owner or admin can change the workspace's brand settings) is unchanged.
Why
The page implied you can share a brand kit with other people, but the Studio app has no way to do that, and kits made or shared on app.heygen.com don't appear in the app. Users asked how to share a kit and couldn't find it. This keeps the one true, useful fact (workspace members already see the workspace's kits) and says plainly that sharing outside the workspace isn't available, without promising it.
How
Text-only change to one section. No other page links to the old
#shared-kitsanchor.Test plan
bun run lintpassesmint dev(new heading and text present)