Repository navigation
chore(producer): keep the probe-needs-a-browser doc on its own function - #7554
Merged
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Approving at e9ead56d. No blockers.
- The change touches only comments in
probeStage.ts.probeRequiresBrowser's doc comment now sits onprobeRequiresBrowseragain, andchecksVariablesInBrowserkeeps only its own one-line doc. This resolves the nit I left on #7548. - This is not a fix PR, so it does not need a
fails without the fix:line. - CI at this head: CI, regression, Windows render, Comments, CodeQL and the captures all pass.
Non-blocking: the shortened comment drops the R4 caveat. A known-duration, media-free composition that builds many nodes in its init script is measured statically and must never reach the band's applied cohort. That is the non-obvious invariant behind this predicate. If a later change wants it back, a short pointer to resolveDeShortBand would keep it findable without raising the file's comment share much.
Merged
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The doc comment for
probeRequiresBrowsernow sits directly on that function. A recent change inserted two helpers between the comment and the function, so the long comment described the wrong one. The comment is also cut to its one load-bearing fact.What I measured
Comment-only diff: 4 lines added, 13 removed in
probeStage.ts.oxfmt --checkandoxlintare clean on the file. The comment ratchet reports a lower comment share for the file than before.What I did NOT exercise
No behaviour changes, so I ran no tests or type check locally; CI runs them.
Size
17 lines, comment only. It is a review nit on a change that has already merged, and I have no other open change in this repository to carry it.