Repository navigation
fix(producer): probe sub-composition media defaults - #7550
Open
IceCoooola wants to merge 1 commit into
Open
IceCoooola wants to merge 1 commit into
IceCoooola wants to merge 1 commit into
Conversation
Sub-composition defaults declared on <html> disappear from the DOM during inlining. The browser-probe gate then misses data-var-src bindings, causing renders to use the authored placeholder source. Pass the inliner's variablesByComp table through CompiledComposition and consult the nearest composition scope when checking media bindings. Give anonymous mounts distinct runtime scopes and reserve IDs as nested mounts are processed, preserving each instance's variable values. Add regression coverage for declared defaults, repeated mounts, nested scopes, and named/anonymous mount collisions. Fixes heygen-com#7505
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix renders using the authored placeholder source when a media element's
data-var-srcrefers to a default declared on its sub-composition's<html>element.Why
Inlining drops that
<html>element. The browser-probe gate could nolonger find the declared default and skipped resolving the media source,
even though preview and snapshot used the correct file.
Related work
Fixes #7505.
Extends #6501, which covered mount-level variable values and defaults
declared on the root composition.
How
variablesByComptable throughCompiledCompositionto the probe gate.without parsing emitted JavaScript.
nested mounts are processed, preventing variable values from being
overwritten by another instance.
Test plan
Validation:
reservation change.
rechecked after the latest change.
The issue's reproduction was rendered with the published version and a
local fix during development, confirming that the resolved default source
replaces the placeholder.
Full workspace validation remains limited by the SDK playground build
error under Node 20.11 and broader test-runner compatibility failures.