Repository navigation
fix(share): explain the hourly review-version limit - #7539
Merged
Merged
Conversation
The review service can now refuse a new version with 429 export_hourly_limit (too many versions in the last hour). It had no sentence, so the person read "Couldn't add this version. Try again." and every retry was refused again. It now says the hourly limit was reached and when to try again, from the server's Retry-After, falling back to "in an hour" when none is sent. The daily limit keeps its "tomorrow" fallback. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![heygengenesis[bot]](https://avatars.githubusercontent.com/in/2913576?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 0 nits
laterIn now takes a per-limit fallback. The daily sentence is unchanged ("tomorrow"), and the hourly one falls back to "in an hour". versionSentence's only internal caller, reviewExport.mjs:217, passes its replay fallback through untouched, so a matched reason still wins. The new tests pass locally (3/3), and all CI on this head is green.
— Genesis
Merged
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a sentence for the review service's new
429 export_hourly_limitrefusal (too many new versions in the last hour):The wait comes from the server's
Retry-After. If none is sent, it falls back to "in an hour". The daily limit's sentence is unchanged and keeps its "tomorrow" fallback.Why
The review service now limits new versions per hour as well as per day.
versionSentenceonly knew the daily reason, so an hourly refusal fell through to "Couldn't add this version. Try again." That told the person to retry immediately, and every retry within the hour was refused again. Now they see what happened and how long to wait.Related work
The server-side limit change is in a separate repository.
How
export_hourly_limitentry inSAID.laterInnow takes the fallback to use when the server sends noRetry-After, so each limit falls back to its own window.Test plan
packages/share/tests/reviewVersionSentences.test.mjscovers the hourly sentence with a wait, both fallbacks, and the daily sentence rounding to hours. Without this change, the hourly test gets the generic "Try again" sentence and fails.node --test tests/*.test.mjsinpackages/share: 60 pass, 0 fail.oxfmt --checkandoxlintare clean on both files.🤖 Generated with Claude Code