Skip to content

fix(cli): word audio read no-stems warning by missing content - #7489

Open
rudy-07 wants to merge 1 commit into
heygen-com:mainfrom
rudy-07:fix/audio-read-no-stems-warning
Open

rudy-07 wants to merge 1 commit into
heygen-com:mainfrom
rudy-07:fix/audio-read-no-stems-warning

Conversation

@rudy-07

@rudy-07 rudy-07 commented Nov 10, 2026

Copy link
Copy Markdown

What

Updates the warning emitted by hyperframes audio --read when stem separation is skipped at local or fast quality. The warning now describes what content is omitted instead of instructing the caller to pass --quality best.

Why

Fixes the remaining item of #7204.

When audio --read runs under --quality local or --quality fast, the CLI previously emitted:
not separated into stems: quality <quality> keeps audio on this machine; --quality best separates it through HeyGen

When the CLI is invoked non-interactively or wrapped by host tools and agents that cannot supply flags, directing the caller to pass --quality best provides an action they cannot execute. Stating what is missing ("music, and effects under speech, are not read") communicates the read status directly without prescribing flags.

Related work

Fixes #7204.
Follows #7345 (which resolved item 1 of #7204 by adding --layer).

How

In packages/cli/src/audio/read/read.ts, update stemsFor() to push not separated into stems: music, and effects under speech, are not read when quality !== "best". Updated the corresponding regression assertion in packages/cli/src/audio/read/read.test.ts.

Test plan

fails without the fix: packages/cli/src/audio/read/read.test.ts > keeps audio on the machine by default, and reads neither voice nor effects from a bare mix expects the new warning text.

  • All 17 read.test.ts tests pass.
  • Linter and formatter checks clean: bun run lint and bun run format:check.
  • Fallow and typecheck checks clean across the workspace.
  • Comment citation and ratchet checks clean: node scripts/check-comment-citations.mjs and node scripts/comment-ratchet.mjs.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

audio --read: accept an already-single-stem recording, and word the no-stems warning by what is missing

1 participant