Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the warning emitted by
hyperframes audio --readwhen stem separation is skipped at local or fast quality. The warning now describes what content is omitted instead of instructing the caller to pass--quality best.Why
Fixes the remaining item of #7204.
When
audio --readruns under--quality localor--quality fast, the CLI previously emitted:not separated into stems: quality <quality> keeps audio on this machine; --quality best separates it through HeyGenWhen the CLI is invoked non-interactively or wrapped by host tools and agents that cannot supply flags, directing the caller to pass
--quality bestprovides an action they cannot execute. Stating what is missing ("music, and effects under speech, are not read") communicates the read status directly without prescribing flags.Related work
Fixes #7204.
Follows #7345 (which resolved item 1 of #7204 by adding
--layer).How
In
packages/cli/src/audio/read/read.ts, updatestemsFor()to pushnot separated into stems: music, and effects under speech, are not readwhenquality !== "best". Updated the corresponding regression assertion inpackages/cli/src/audio/read/read.test.ts.Test plan
fails without the fix:
packages/cli/src/audio/read/read.test.ts>keeps audio on the machine by default, and reads neither voice nor effects from a bare mixexpects the new warning text.read.test.tstests pass.bun run lintandbun run format:check.node scripts/check-comment-citations.mjsandnode scripts/comment-ratchet.mjs.