Repository navigation
Conversation
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
5 of 6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A new Linux-only preflight check runs
fc-listbefore the browser launches. Zero fonts fails the render with the fix in the hint, anddoctorshows the font count.Why
On Linux, when fontconfig lists zero fonts,
hyperframes renderexits 0 and every frame comes out with no text at all, even though HyperFrames embeds a web font.doctorpassed too, so there was no hint anything was wrong.Related work
Fixes #7406
How
checkSystemFonts()inpackages/cli/src/browser/preflight.tscounts non-emptyfc-listlines and joinsrunEnvironmentChecks()when the browser is included, sorenderstops on the failed outcome anddoctorlists it. A missing or failingfc-listonly warns, since the binary on PATH may not be the fontconfig Chromium loads. Off Linux the check is a no-op.Test plan
How was this tested?
New tests in
packages/cli/src/browser/preflight.test.ts: 0 lines fails, N lines passes, missing or failingfc-listwarns, no-op off Linux. 39 preflight tests and 34 doctor tests pass, CLI typecheck is clean, oxlint and oxfmt are clean. Ran the built CLI here:doctorreportsSystem fonts: fontconfig fonts: 1877, matchingfc-liston this machine.Note:
checkandsnapshotdo not run the shared preflight, so they are not covered by this change.