Repository navigation
chore: release v0.9.19 - #7290
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
There was a problem hiding this comment.
Requesting changes at 67e1fdaa: the release notes no longer match what this PR would ship.
Blocker: main moved after this branch was cut. #7287 (b56e2c03, "fix(cli): a font missing from this computer no longer stops a cloud render, and is named") landed on main after 6abc62a1. This branch is 1 behind main. Merged as it is, v0.9.19 would publish #7287 to npm, but releases/v0.9.19.md and docs/changelog.mdx list only #7283, and the PR body still calls #7283 "the only change on main since v0.9.18". The CI run on this head also never built #7287.
Fix: rebase onto current main, re-run bun run release:prepare 0.9.19 so the notes cover both #7283 and #7287 (and add the CLI tag), then update the PR body. The alternative is to state on purpose that #7287 is held back, which this merge path can't do.
Verified at this head (no other issues):
- All 19 version fields go from
0.9.18to0.9.19, and no other version string changes. - The release notes and changelog entry match #7283, and the compare link names v0.9.18.
- All 11 Actions workflows on
67e1fdaasucceeded, including regression, Windows render, and preview-regression. - The "fails without the fix" rule is met where the fix lives: #7283's body names the test "lands every frame where preview does when one worker renders in order" (expects
[30, 1], gets[30, 0]without the fix). This PR is a version bump and doesn't need its own line.
Not blocking: The "Desktop walked with packed packages" item is still unchecked. Also, the fix only covers a set that interrupts a tween still running on the same property, so it isn't every local export.
67e1fda to
1a90e37
Compare
1a90e37 to
767d7d1
Compare
There was a problem hiding this comment.
Approving at 767d7d18. The blocker from my last review is fixed.
- The branch is one commit on top of current
main(b56e2c03): 1 ahead, 0 behind. v0.9.18...mainholds exactly #7283 and #7287.releases/v0.9.19.mdanddocs/changelog.mdxname both, with matching commit links. The changelog adds the CLI tag, and the compare link names v0.9.18.- All 19 version fields go from
0.9.18to0.9.19, and nothing else in the diff changes. - CI on this head passed: CI, regression, Windows render verification, preview-regression, PR captures, Docs, CodeQL, Lambda arm64 image, and both player perf runs. The cancelled runs were older duplicates on the same SHA, and later runs of the same workflows passed.
- The "fails without the fix" rule is met where the fixes live (#7283 and #7287). This PR is a version bump.
Not blocking: "Desktop walked with packed packages" is still unchecked in the test plan.
What
Release v0.9.19: version bump,
releases/v0.9.19.md, and the docs changelog. Merging publishes to npm.Why
Ships the two changes on
mainsince v0.9.18: a video that looks right in preview and renders blank when asetinterrupts a running tween (#7283), and a cloud render that stopped when a project used a font with no file on this computer (#7287).No visible change
Version bump and changelog only. Each change was captured in its own PR.
Test plan
bun run release:prepare 0.9.19passed on currentmain, and the release notes name both changes. The compare link names v0.9.18.main, and the local tag was not pushed.