Repository navigation
Conversation
SanHsien
added a commit
to SanHsien/hyperframes
that referenced
this pull request
Nov 6, 2026
Re-verified the nine merged PRs in heygen-com#7266-heygen-com#7288 against fork file:line and reverse-apply checks; none needs a new port. The six open PRs (heygen-com#7266, heygen-com#7269, heygen-com#7281, heygen-com#7282, heygen-com#7285, heygen-com#7286) are pinned as monitored with revisit conditions; monitored 99 -> 105. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
During the check overlap pass, geometry seeks skip WebGL draws but still uploaded a full-size source texture for every sample, so each sample of a graded image reserved another decoded frame in the GPU process until the pass ended. Gate the texture upload calls with the same draw gate, so a seek nothing paints performs no GPU uploads.
sx4im
force-pushed
the
fix-7259-check-gpu-uploads
branch
from
November 9, 2026 19:09
952fd2b to
405c0f4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7259
With the hardware GPU on macOS,
hyperframes checkgrew the Chrome GPU process by about one decoded frame per overlap sample for graded images. The overlap pass seeks with WebGL draws skipped, but the seek still ran the full graded-frame paint, which re-uploaded the source image into a texture for a frame nothing ever paints. Each upload reserved another full-size GPU backing store until the pass ended.This gates the texture upload calls (
texImage2D,texSubImage2D,copyTexImage2D, and the compressed variants) with the same draw gate geometry seeks already use. The next real seek re-uploads before drawing, so presented frames are unchanged.How verified:
captureCompositionFrame.webglDraws.browser.test.tscounts realtexImage2Dcalls in headless Chrome: it fails before the fix (upload happens on a geometry seek) and passes after (0 uploads on a geometry seek, 1 on the following pixel seek, repaint still correct).