Repository navigation
fix(cli): check sees an SVG stroke drawing on, so it no longer calls it a dead stretch - #7250
Merged
Merged
Conversation
…it a dead stretch
Contributor
There was a problem hiding this comment.
Verdict: APPROVE · 0 blockers · 0 important · 0 nits · head 6ec1e38f
The fails without the fix: test holds. In real Chromium, with the two properties removed it fails with an identical sweep signature; with them in, all 48 Chromium tests in the file pass. All workflows on this head are green.
Scope
Read both files. paintChannel hashes raw computed values, and color already made every element's content-paint hash non-empty. So adding two inherited properties only changes the hash when a dash value actually changes; a still dasharray stays still. No prior reviews.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 5, 2026
SanHsien
added a commit
to SanHsien/hyperframes
that referenced
this pull request
Nov 6, 2026
…view Adopts heygen-com#7250 (SVG stroke drawing is not a dead stretch), heygen-com#7248 (contract check reads a timeline registered in a local script), heygen-com#7252 (comma-list selectors hidden by authored CSS), heygen-com#7238 (snapshot and preview show a clip on the render frame), heygen-com#7237 (stalled cloud upload retries) and heygen-com#7251 (per-scene SVG id namespacing), with prerequisite heygen-com#6829. Defers heygen-com#7246 (needs the delivery limiter from heygen-com#6940) and heygen-com#7232 (needs the WebKit decode-first pipeline), with conditions in the ledger. Watermark advances to b108f85. Co-authored-by: Miguel Ángel <miguel.sierra@heygen.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SanHsien
added a commit
to SanHsien/hyperframes
that referenced
this pull request
Nov 6, 2026
…view to heygen-com#7250 Adopts heygen-com#7310 (MPEG-4 Part 2 / MJPEG get browser-playable copies), heygen-com#7316 (check_report counts the copies a check waited for) and heygen-com#7317 (render reads a composition src like the preview and refuses paths outside the project). Defers heygen-com#7309 (needs heygen-com#6912); heygen-com#7314 does not apply. PR axis advances to heygen-com#7250 (heygen-com#7243 closed unmerged, heygen-com#7249 open and pinned as monitored; monitored 96->97). Co-authored-by: Miguel Ángel <miguel.sierra@heygen.com> Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
checkno longer reportsdead_stretch("Nothing on screen changes for N s") while an SVG stroke draws on. The motion audit's "nothing moves" reads the same signature, so it stops saying it too.Why
A whiteboard film drew its lines with the usual stroke draw-on (
stroke-dasharraywith a tweenedstroke-dashoffset). The rendered frames showed each line drawing, but the craft pass reported the stretches as dead.The liveness signature (
motion-signature.browser.js) reads each element's box, opacity and paint (color,textShadow,fill,stroke). A dash offset tween moves none of them: the path's box and colour stay the same while the visible part of the line grows. So two frames of a line half drawn and fully drawn signed the same.Released 0.9.15 on a 12 s film whose only motion is one path drawing on over 10 s:
dead_stretch"Nothing on screen changes for 9.00 s (0.00–9.00 s)".How
strokeDashoffsetandstrokeDasharrayjoin the content paint channel, besidefillandstroke. Both are computed style in Blink, so attribute, CSS and inline-style tweens all show up.Test plan
motion-signature.browser.chromium.test.ts"sees an SVG stroke drawing on, which moves no box and no color": in real Chromium, changing a path'sstroke-dashoffsetchanges both the sweep and the liveness signatures. It fails with the two properties taken out.motion-signature.browser.chromium.test.ts,motion-signature.browser.test.ts,motion-sample.browser.test.tsandcraftAudit.test.ts(110) pass three runs in a row, with the Chromium suite running (not skipped).check --jsonon the 12 s draw-on film above:ok: true, no craft or motion findings. Released 0.9.15 on the same film reports the 9 sdead_stretch.Size
Two lines of source in one file and one test. One fix: the liveness signature sees a dash offset.