Repository navigation
refactor(producer): deferred frame extraction moves out of the distributed code - #7240
Merged
Merged
Conversation
…buted code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… integration lane Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
![heygengenesis[bot]](https://avatars.githubusercontent.com/in/2913576?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 0 nits · c6be942
Checked that the move changes no behaviour: shownDeferredFrameIndexes and the per-video extraction match the old chunkFrames.ts code line for line. sourceOf still throws inside the per-video async callback, so a missing planDir source still rejects with the same RenderChunkValidationError. The only new behaviour is that signal is now passed through to extractVideoFramesRange, which helps.
Scope
Read all 6 files. CI and Comments are green at c6be942. The branch is 4 commits behind main, with no conflicts.
— Genesis (Claude)
Merged
2 of 3 tasks
SanHsien
added a commit
to SanHsien/hyperframes
that referenced
this pull request
Nov 6, 2026
…view Adopts heygen-com#7240 (deferred frame extraction leaves the distributed code), heygen-com#7241 (a capture segment extracts and deletes its own frames), heygen-com#7255 (segmented and sequential capture check drawElement samples), heygen-com#7254 (normalize-audio --reference stops short of the peak ceiling), heygen-com#7256 (engine names a failed script's origin first), heygen-com#7258 (SVG gradient text judged by its stops) and heygen-com#7242 (windowed source frames, off unless HF_VIDEO_FRAME_WINDOW=true). Release v0.9.17 is not synced wholesale; the producer packed budget takes upstream's +12000 from this range. Watermark advances to 32eb4c3. Co-authored-by: Vance Ingalls <vance@heygen.com> Co-authored-by: Miguel Ángel <miguel.sierra@heygen.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves deferred frame extraction (
shownDeferredFrameIndexes,extractDeferredFrames,contiguousRuns) out ofdistributed/chunkFrames.tsintorender/deferredVideoFrames.ts. No behavior change.Why
Local segmented renders are about to extract per segment the way cloud chunks already extract per chunk. Both should use one extractor. First of a stack of 3, see the last PR for the whole picture.
How
chunkFrames.tskeeps its remote-URL and plan-directory lookup and its typed errors, and passes them in assourceOfandonMissingFrame. Its plan-shaped adapter is renamedshownPlanFrameIndexes, since the fallow gate rejects a duplicate export name. Its only importer isrenderChunk.ts.Test plan
chunkFrames.test.tspasses unedited.deferredVideoFrames.test.ts, including a real ffmpeg extraction that comes up short.🤖 Generated with Claude Code