Repository navigation
fix(lint): compositions in .hyperframesignore no longer count as the project's - #7239
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
There was a problem hiding this comment.
Verdict: REQUEST CHANGES · 1 blocker · 0 important · 0 nits · head efa65615
The code looks right; the only blocker is CI. The Comments check fails and the PR body doesn't explain it: NEW file over its package's comment share: packages/lint/src/projectIgnore.ts is 18.8% (3/16), the package is 10.8%. ↓ inline
Scope
Read the full diff. The lintProject compositions walk is the only path into blank_root_with_standalone_composition. Publish keeps the same rules: the defaults and .hyperframesignore loading moved without changes. Paths are built with /, so matching holds on Windows. Locally project.test.ts passes 87/87. With the ignored.ignores line removed, the new test fails (['index.html', …(1)] ≠ ['index.html']), so the fails without the fix: line holds. All other CI was green; CodeQL and Windows render were still running. No earlier reviews.
— Genesis V2 (Lane B)
|
Fixed at 4898cab: |
…eview Adopts or partially adopts 11 groups: multi-worker tween replay behind the timeline stand-in (heygen-com#7231), template entries in the shared compile stage (heygen-com#7217), HYPERFRAMES_CACHE_DIR and HYPERFRAMES_CONFIG_DIR for every per-user cache and settings file (heygen-com#7224, heygen-com#7229; HeyGen credentials stay under HEYGEN_CONFIG_DIR), WebKit audio clock (heygen-com#7225), packet-based video length (heygen-com#7233), HLG tone mapping (heygen-com#7234), fetch network cause (heygen-com#7236), .hyperframesignore in lint (heygen-com#7239), info --media (heygen-com#7235), lint priority (heygen-com#7244), check --budget (heygen-com#7245) and the unknown-command answer (heygen-com#7247). bun.lock gains only the lint `ignore` edge from heygen-com#7239, already resolved. Watermark advances to 0a6746e. Co-authored-by: Jerrai <jerrai@heygen.com> Co-authored-by: Miguel Ángel <miguel.sierra@heygen.com> Co-authored-by: WaterrrForever <miao.yang@heygen.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What
The project lint no longer reads compositions that
.hyperframesignoreleaves out. A blankindex.htmlbeside an archived standalone composition in an ignored folder no longer failscheck,snapshot,renderandpublishwithblank_root_with_standalone_composition, and an ignored file's own findings no longer count.Why
Someone kept an old standalone video under
compositions/<folder>/index.htmland listed that folder in.hyperframesignore.checkstill found it, reportedblank_root_with_standalone_composition, andsnapshotaborted with "the default index.html entry is blank". The ignore file was read only when building the publish and cloud archives, so the lint walk ofcompositions/had no way to know the folder was not part of the project.How
The ignore rules (root
renders/andsnapshots/, dotfiles, then the project's.hyperframesignore) move frompublishProject.tsinto@hyperframes/lintasprojectIgnore(projectDir), so lint and publish read one rule set. Publish calls it in place of its private copy.lintProject's walk ofcompositions/skips every file and folder it matches.@hyperframes/lintgains theignoredependency the CLI already uses, at the same range. The dotfile rule stays the unanchored.*, so it matches at any depth and a.hyperframesignorenegation can still re-include a hidden folder (#3859).The root-level
multiple_root_compositionsrule is unchanged: it guards files the runtime can open as entry points, and is not part of this report.Test plan
project.test.ts"does not count a composition in a folder the project's .hyperframesignore leaves out": a blank root,compositions/archive/index.htmlwith a timed clip, andcompositions/archive/in.hyperframesignore; lint reads onlyindex.htmland reports noblank_root_with_standalone_composition. It fails with the skip removed.project.test.ts(87) passes three runs in a row;publishProject.test.tsandpublishProject.srcset.test.ts(150) pass with publish on the moved rules.lint --jsonon the reported shape (blank root, a standalone composition incompositions/archive/) reportsblank_root_with_standalone_composition; withcompositions/archive/in.hyperframesignoreit does not.check,snapshot,renderandpublishread the same finding from this lint..hyperframesignoreparagraph indocs/packages/cli.mdx.projectIgnore; the new file stays under the package's comment share, and the dotfile note it had in publish is in this body.Size
About 20 lines of source in five files, one test and two doc lines. One fix: lint honours the project's ignore file.