[terencecho]

Record CLI sharing attempts, authentication, accepted uploads, completed videos, processing, recovery, and existing-link retrieval through the existing telemetry controls. Provide interaction helpers for the local Studio follow-up. Payloads use fixed fields and allowlisted failure categories; they exclude project paths, titles, links, credentials, and raw errors.

Restacked only the telemetry commit onto #7135 after #7137 merged. The source-capture, target-identity, upload-recovery, and explicit video-only safeguards remain inherited from that parent. Recovery is counted before status reconciliation clears saved state, and a completed video is counted even when its review link is disabled. Link reactivation cannot create a first share outside the audience/rollout checks.

Validation at 154d9a8eb:

• 51 CLI sharing/command tests and 87 sharing-package tests passed.
• Real telemetry-client tests verify that persisted opt-out changes and both privacy environment variables stop event queueing in a long-lived process.
• CLI build/typecheck, lint, formatting, comment checks, and all repository commit hooks including Fallow passed.
• Independent review findings addressed; no remaining concrete findings.
• Full CI and CodeQL are running on this head.

Local Studio interaction wiring belongs to the subsequent Studio slice. Signed-in end-to-end sharing and production telemetry delivery remain unverified. #7135 stays draft; this PR is ready for review, not queued to merge.

[terencecho]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat(share): measure local sharing outcomes and document rollout #7138 👈 (View in Graphite)
• feat: unify video sharing across CLI and local Studio #7135 : 1 other dependent PR (#7140 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[jrusso1020]

Reviewed at 154d9a8eb1ca9d9cf2e41b6fa1f48a21412dbd0c, the six-file increment over #7135 at ce7aabdcdf5e47805a9699482179570abd2e6637 (verified ancestor and tree-identical to the previously reviewed #7137 head 8a3a0cc3a1d7e3207f734ea66016e98c92fee419).

No blocking findings. service.ts:45 captures recovery before reconciliation clears pending state; telemetry.ts:65 deduplicates admission per attempt, and complete counts a ready video from the kernel's onAdded callback even when its link is disabled. Status polling and existing-link retrieval do not count new videos. New payloads contain surface/action enums, a random attempt UUID, a recovery boolean, fixed failure categories, or the declared interaction enum fields; no path, title, link, token or raw error is forwarded. Emission refreshes the existing persisted/privacy-env opt-out controls. Its config-read, posture-reset and trackEvent calls are inside the fail-silent boundary; mutation failures are rethrown unchanged.

Read all six changed files, the CLI consumer, and kernel upload/completion/reconciliation boundaries; independently adversarially checked retry, disabled-link and failure scenarios. Validation: full bun run build passed; Node 22 vitest run src/share src/commands/share.test.ts passed 51 tests across 7 files, including actual telemetry-client opt-out tests; node --test tests/*.test.mjs in packages/share passed 87 tests. Service tests mock render/upload execution; kernel tests exercise their own boundary fakes. Studio interaction helpers are scaffolding for the next slice, not wired UI instrumentation. No signed-in end-to-end sharing or production telemetry delivery exercised; standard client identity enrichment remains existing behavior.

Need: yes · Size: ok · Reuse: existing telemetry client/config and share kernel callbacks · Simpler: already minimal · Structure: fine
Risk: low — bounded observability increment with existing consent and sharing guards preserved.

— hf-review

Verdict: APPROVE
Reasoning: The increment separates attempts, upload admission, completed videos and link retrieval without introducing private share data or altering upload outcomes.