Repository navigation
feat(cli): billing top-up is renamed to add-credits with no alias - #7121
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Approve at 8d0e0856. No blockers.
billing.ts: removing the alias line meanstop-upnow goes down the unknown-action path. It prints "Usebilling subscribeorbilling add-credits." and callsfailCommand()before anything is read or opened. The positional help and the description already list onlysubscribe | add-credits.- I found no other
top-upinpackages/cli,skillsordocs. The one hit inpackages/coreis the unrelated font top-up. - The fails-without-the-fix claim holds. I ran it locally:
billing.test.tspasses 5/5 at head. With the old mapping restored, "refuses the old nametop-uplike any unknown action, naming the valid ones" fails and the other 4 pass. - CI was still running when I reviewed (CI, CodeQL, Windows render). The checks that had finished were green.
Collaborator
Author
|
Remote run on the first layout of this change: billing.test.ts 5 passed. With the mapping put back, the refusal test fails (1 failed, 4 passed), so it catches the alias. The pushed head only re-indents the test body for the formatter; CI's format check covers that. |
This was referenced Nov 4, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
billing top-upis gone. The command isbilling add-creditsonly (HeyGen's name, add-on credits);top-upis now an unknown action and gets the usual error, "Usebilling subscribeorbilling add-credits." No alias, no notice. A search ofpackages/cli,skillsanddocs(changelog history aside) finds no othertop-up.How
One line in
billing.ts(thetop-uptoadd-creditsmapping) is deleted.Tests
billing.test.ts:add-creditsopens the credits page;top-upis refused with the error above and opens nothing.Fails without the fix: with the mapping back, the
top-uptest fails (it would open the credits page instead of refusing).The billing tests ran on a remote box (run in flight when this was pushed; result in a comment).
Size
A one-line removal Miguel asked for, kept separate so it can land before the next release.