Skip to content

feat(cli): billing top-up is renamed to add-credits with no alias - #7121

Merged
miguel-heygen merged 1 commit into
mainfrom
feat/cli-drop-top-up-alias
Nov 4, 2026
Merged

miguel-heygen merged 1 commit into
mainfrom
feat/cli-drop-top-up-alias

Conversation

@miguel-heygen

Copy link
Copy Markdown
Collaborator

What

billing top-up is gone. The command is billing add-credits only (HeyGen's name, add-on credits); top-up is now an unknown action and gets the usual error, "Use billing subscribe or billing add-credits." No alias, no notice. A search of packages/cli, skills and docs (changelog history aside) finds no other top-up.

How

One line in billing.ts (the top-up to add-credits mapping) is deleted.

Tests

billing.test.ts: add-credits opens the credits page; top-up is refused with the error above and opens nothing.
Fails without the fix: with the mapping back, the top-up test fails (it would open the credits page instead of refusing).
The billing tests ran on a remote box (run in flight when this was pushed; result in a comment).

Size

A one-line removal Miguel asked for, kept separate so it can land before the next release.

@heygengenesis heygengenesis Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve at 8d0e0856. No blockers.

  • billing.ts: removing the alias line means top-up now goes down the unknown-action path. It prints "Use billing subscribe or billing add-credits." and calls failCommand() before anything is read or opened. The positional help and the description already list only subscribe | add-credits.
  • I found no other top-up in packages/cli, skills or docs. The one hit in packages/core is the unrelated font top-up.
  • The fails-without-the-fix claim holds. I ran it locally: billing.test.ts passes 5/5 at head. With the old mapping restored, "refuses the old name top-up like any unknown action, naming the valid ones" fails and the other 4 pass.
  • CI was still running when I reviewed (CI, CodeQL, Windows render). The checks that had finished were green.

@miguel-heygen

Copy link
Copy Markdown
Collaborator Author

Remote run on the first layout of this change: billing.test.ts 5 passed. With the mapping put back, the refusal test fails (1 failed, 4 passed), so it catches the alias. The pushed head only re-indents the test body for the formatter; CI's format check covers that.

@miguel-heygen
miguel-heygen added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit d21877e Nov 4, 2026
70 checks passed
@miguel-heygen
miguel-heygen deleted the feat/cli-drop-top-up-alias branch November 4, 2026 01:51
This was referenced Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant