Skip to content

test(skills): core-skills test matches the reverse start wording - #7114

Merged
miguel-heygen merged 1 commit into
mainfrom
fix/core-skills-test-reverse-wording
Nov 3, 2026
Merged

miguel-heygen merged 1 commit into
mainfrom
fix/core-skills-test-reverse-wording

Conversation

@miguel-heygen

Copy link
Copy Markdown
Collaborator

What

Main's Test (support) is red: scripts/check-core-skills.test.mjs still expects the reverse-any-video start.md wording from before #7101 ("ask once for that total"), while start.md now says "run npx hyperframes billing top-up --needed <total> once for that total". The red job ejects every PR from the merge queue.

How

The test matches the wording start.md has now, and accepts both command names (top-up and add-credits) so the billing rename that is open next does not turn it red again. Test only, no skill text changes.

Tests

check-core-skills.test.mjs: 9 passed. Fails without the fix: on current main the same test fails (not ok 5, the old pattern finds no match in start.md).

Size

A lone test fix that unblocks main's merge queue; nothing else open can carry it.

@heygengenesis heygengenesis Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve at 70df6244.

  • Ran node --test scripts/check-core-skills.test.mjs on main (341fdd3): not ok 5, 8 pass / 1 fail. On this head: 9 pass / 0 fail. The diff against main is this one test file only.
  • The new pattern matches start.md L67–68 as the file reads now. \s+ covers the line break after "refused step", and the rest of the sentence is on one line.
  • The (?:top-up|add-credits) alternation lets the test pass before and after the billing rename. Folding the old loose --needed <total> assertion into the full-sentence match also makes the test stricter.
  • The body has a "Fails without the fix:" line naming this test, and I reproduced that failure.

@miguel-heygen
miguel-heygen added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit 9304d73 Nov 3, 2026
68 checks passed
@miguel-heygen
miguel-heygen deleted the fix/core-skills-test-reverse-wording branch November 3, 2026 22:33
This was referenced Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant