Repository navigation
test(skills): core-skills test matches the reverse start wording - #7114
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Approve at 70df6244.
- Ran
node --test scripts/check-core-skills.test.mjson main (341fdd3):not ok 5, 8 pass / 1 fail. On this head: 9 pass / 0 fail. The diff against main is this one test file only. - The new pattern matches
start.mdL67–68 as the file reads now.\s+covers the line break after "refused step", and the rest of the sentence is on one line. - The
(?:top-up|add-credits)alternation lets the test pass before and after the billing rename. Folding the old loose--needed <total>assertion into the full-sentence match also makes the test stricter. - The body has a "Fails without the fix:" line naming this test, and I reproduced that failure.
This was referenced Nov 4, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Main's
Test (support)is red:scripts/check-core-skills.test.mjsstill expects the reverse-any-videostart.mdwording from before #7101 ("ask once for that total"), whilestart.mdnow says "runnpx hyperframes billing top-up --needed <total>once for that total". The red job ejects every PR from the merge queue.How
The test matches the wording
start.mdhas now, and accepts both command names (top-upandadd-credits) so the billing rename that is open next does not turn it red again. Test only, no skill text changes.Tests
check-core-skills.test.mjs: 9 passed. Fails without the fix: on current main the same test fails (not ok 5, the old pattern finds no match instart.md).Size
A lone test fix that unblocks main's merge queue; nothing else open can carry it.