Repository navigation
feat(cli): billing top-up becomes add-credits, top-up stays as an alias - #7105
miguel-heygen wants to merge 3 commits into
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 1 nit · head 6125e9d
- nit:
scripts/check-core-skills.test.mjs:40,49still says "top up" / matchesbilling top-up --needed <total>; it passes only via the|--needed <total>branch. Worth renaming toadd-creditsso the pin tracks the new command.
Scope
Read the full diff (9 files). The alias maps top-up → add-credits before any branch reads action, so wait logic, page choice and the timeout message are unchanged. The top-up case in billing.test.ts would fail without the mapping (unknown action → console.error + failCommand). Grepped the tree at head: no remaining billing top-up outside changelogs/releases and the nit above. CI was still running when this was posted; the merge is held by the review gate.
6125e9d to
80a1898
Compare
|
Superseded: the add-credits rename merged inside #7068, which was stacked on it. |
What
hyperframes billing top-upis nowhyperframes billing add-credits, HeyGen's product name: add-on credits are spent separately from the plan's monthly credits and can exceed it, so "top-up" was the wrong word.top-upstill works as a hidden alias (not listed in help, no deprecation notice), so old docs and agents keep working.Changes
billing: new action name and help text ("Buy add-on credits, used separately from your plan's monthly credits");top-upmaps toadd-creditsbefore anything else reads it.billing add-credits.Tests
billing.test.ts:add-creditsandtop-upboth open the credits page, with nothing printed about a rename.top-upcase red (1 failed, 2 passed); with it, 27 passed acrossbilling.test.tsandv3.test.ts, and the media-use message test passes (20).Size
A lone rename kept apart from the open sign-in PR on request; nothing else open can carry it.