Repository navigation
chore(studio-server): raise the package size budget for the preview features - #7044
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Approving at c016c07. Budget-only change, two lines in scripts/package-size-budgets.json. The new numbers match the script's own formula: ceil(measured × 1.05) gives 156,922 → 164,768, rounded to 164,800, and ~615 kB → 646,000. The tarball is clean: files is dist + README, tsup has no sourcemap option, and the only extra output is .d.ts. That means the growth is real code, not maps or tests. Build is green on this head, so main's current size stays above the 0.85 ratchet floor. This is a chore, not a fix, so it doesn't need a 'fails without the fix' line.
Merged
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Raises the
@hyperframes/studio-serversize budget inscripts/package-size-budgets.json: packed 154,437 to 164,800 bytes, unpacked 603,489 to 646,000.Why
The Build job fails on two approved PRs (the preview still frame and the preview error kinds) with
@hyperframes/studio-server packed size 155987 bytes is over its budget of 154437 by more than 1%. Both add real server code in the preview route and the proxy helpers.Checked the tarball first:
filesisdistandREADME.md, tsup builds only the listed entries with no source maps, and a pack of both PRs merged lists 50 files with no.map, test or fixture. It is 156,922 bytes packed and about 615 kB unpacked, so the growth is code, not stray files.New budgets are the measured size plus the 5% headroom
verify-packed-manifests.mjsalready uses.Testing
bun run verify:packed-manifestson this change passes with the two features merged in.Size
A four-line budget change on its own so two approved PRs can rebase on it and merge; it cannot ride in either one.