Skip to content

chore(studio-server): raise the package size budget for the preview features - #7044

Merged
miguel-heygen merged 1 commit into
mainfrom
chore/studio-server-size-budget
Nov 3, 2026
Merged

miguel-heygen merged 1 commit into
mainfrom
chore/studio-server-size-budget

Conversation

@miguel-heygen

Copy link
Copy Markdown
Collaborator

What

Raises the @hyperframes/studio-server size budget in scripts/package-size-budgets.json: packed 154,437 to 164,800 bytes, unpacked 603,489 to 646,000.

Why

The Build job fails on two approved PRs (the preview still frame and the preview error kinds) with @hyperframes/studio-server packed size 155987 bytes is over its budget of 154437 by more than 1%. Both add real server code in the preview route and the proxy helpers.

Checked the tarball first: files is dist and README.md, tsup builds only the listed entries with no source maps, and a pack of both PRs merged lists 50 files with no .map, test or fixture. It is 156,922 bytes packed and about 615 kB unpacked, so the growth is code, not stray files.

New budgets are the measured size plus the 5% headroom verify-packed-manifests.mjs already uses.

Testing

bun run verify:packed-manifests on this change passes with the two features merged in.

Size

A four-line budget change on its own so two approved PRs can rebase on it and merge; it cannot ride in either one.

@heygengenesis heygengenesis Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at c016c07. Budget-only change, two lines in scripts/package-size-budgets.json. The new numbers match the script's own formula: ceil(measured × 1.05) gives 156,922 → 164,768, rounded to 164,800, and ~615 kB → 646,000. The tarball is clean: files is dist + README, tsup has no sourcemap option, and the only extra output is .d.ts. That means the growth is real code, not maps or tests. Build is green on this head, so main's current size stays above the 0.85 ratchet floor. This is a chore, not a fix, so it doesn't need a 'fails without the fix' line.

@miguel-heygen
miguel-heygen added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit b22af8f Nov 3, 2026
105 of 107 checks passed
@miguel-heygen
miguel-heygen deleted the chore/studio-server-size-budget branch November 3, 2026 00:02
@jrusso1020 jrusso1020 mentioned this pull request Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant