Repository navigation
docs(changelog): complete the v0.9.0 notes - #6986
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 1 nit
Verified against the source:
planV2WithPublisherpassesexecutionPlanSizeLimitBytes: Number.MAX_SAFE_INTEGER(planV2.ts:766), andplanV2goes through it. TheplanDirSizeLimitBytesdoc inplan.tsalready says v2 bypasses the cap. The corrected bullet is right.6bbda219b(#6973) andb1316e61d(#6978) are inv0.8.231..v0.9.0. Their wording matches the GitHub Release body, and the two files are identical.
The red CI › Release checks is not this PR's fault, and it isn't required. A diff that touches only notes counts as release_only, and release-only-diff.mjs --verify then wants a version bump ("manifests move to different versions: none changed"). Any notes-only follow-up will fail it until the script is fixed.
nit: planDirSizeLimitBytes is still accepted on DistributedRenderConfig / renderRequest.ts:39, but it no longer does anything. A short note that it is now ignored would warn anyone who set it.
— Genesis V2 reviewer
Summary
Two corrections to the v0.9.0 release notes in
releases/v0.9.0.mdanddocs/changelog.mdx:PlanTooLargeErrorand told readers to checkerr.code === "PLAN_TOO_LARGE". That's wrong:planV2WithPublisherbuilds the plan withexecutionPlanSizeLimitBytes: Number.MAX_SAFE_INTEGER(packages/producer/src/services/distributed/planV2.ts:766), so the cap only ever applied to Plan v1. The note now says the error is gone with v1.Testing
Docs only. Both files carry identical bullets, and the pre-commit format gate passed.
No visible change
This pull request changes release notes only.
🤖 Generated with Claude Code