Repository navigation
feat!: remove Plan v1 distributed transport - #6970
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
Edit accuracy: accurate 271 (base branch 271), smooth 95 of thoseThe gate passes. Quarantined, measured but not gated (0) Unstable (2)
|
BREAKING CHANGE: Cloud adapters accept only Plan v2; producer v1 exports are removed.
f6a2268 to
fe537cf
Compare
There was a problem hiding this comment.
Verdict: REQUEST CHANGES · 1 blocker · 0 important · 2 nits · head fe537cff
The GCP workflow no longer rejects an explicit PlanProtocol: "v1". It ignores the field and runs a v2 render, while AWS fails the same input with PLAN_PROTOCOL_UNSUPPORTED (↓ inline).
- nit: the PR body has literal
\nsequences, so it renders as one paragraph. - nit: the optional
Commentscheck is red on a line this PR touched:examples/aws-lambda/README.md:186results.json("no such file in the repo").
Scope
Read in full: the AWS handler/events/SDK, the SAM template and CDK Choice/Fail states, the GCP server/events/SDK/workflow.yaml, and the producer export removals. Checked that PLAN_TOO_LARGE cannot come from the v2 path (planV2WithPublisher passes executionPlanSizeLimitBytes: MAX_SAFE_INTEGER), so dropping it from the non-retryable lists is safe. PlanProducedZeroChunks now fails as PLAN_EMPTY rather than PLAN_TOO_LARGE. That's correct, but callers can see the new error name. The experiment-framework activity models are already Literal["v2"] and keep source_plan_v1_hash, so they're unaffected. On the AWS state machine, an omitted protocol goes to PlanV2 and v1 hits IsPresent → UnsupportedPlanProtocol, which is correct. Both HTTP handlers reject v1 with tests. CI › CI, regression, Windows, Docs and CodeQL were still running at review time.
There was a problem hiding this comment.
Verdict: APPROVE — 2 resolved (GCP explicit-protocol guard fixed in c34f159 with a contract test; PR body newlines), 0 open, 0 new · 3bcd502 → b4bf0cc. The budget change only lowers the gcp-cloud-run unpacked size, matching the smaller package. All workflows are green on this head, including CI, regression and Windows render verification.
There was a problem hiding this comment.
Verdict: APPROVE: 0 open, 0 new · b4bf0cc → ea9b9a2. Both SDKs now reject a stale non-v2 planProtocol before any cloud call, and tests cover that. The deleted semantic-compare scripts are on the deletion allowlist and have no remaining references. Every workflow passed on this head, including CI, regression and Windows render verification.
…eaves the box 240px off seqplainkeys-none-center-r0-root-z100 failed 2 of 3 runs in the merge group for two version-bump PRs (#6970, #6987). In each failing undo the bytes come back but the box stays 240.42px off, which is a Studio undo race, not noise. It stays measured and listed; #6989 tracks the fix, which removes this entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…leaves the box off (heygen-com#6990) * test(studio): quarantine the seqplainkeys case whose undo sometimes leaves the box 240px off seqplainkeys-none-center-r0-root-z100 failed 2 of 3 runs in the merge group for two version-bump PRs (heygen-com#6970, heygen-com#6987). In each failing undo the bytes come back but the box stays 240.42px off, which is a Studio undo race, not noise. It stays measured and listed; heygen-com#6989 tracks the fix, which removes this entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(studio): quarantine the two sibling seqplainkeys center cases with the same undo race center-r30-root (undo box 313.6px off) and center-r0-nested (redo box 240.7px off) ejected 3 and 1 merge-queue entries since 10-30, the same race as center-r0-root. With all three quarantined, the gate passes on the shard results of all 8 failed merge-group runs since 10-30; main's gate fails each. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(studio): quarantine the pct and px seqplainkeys cases with the same undo race The race also hits the pct and px placements: 5 more cases left the box 230-400px off after undo or redo in the 9 failed merge-group runs since 10-30. Merge-group run 41485305789 bounced heygen-com#6990 on px-r0-nested. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Summary
Breaking change
The
planProtocolSDK option and Plan v1 event/result types are removed. AWS and GCP adapter deployments must update their orchestration and handler packages together. This should ship in the next 0.9.0 release.The producer still uses its private execution-plan representation while building Plan v2. The active
sourcePlanV1Hashmanifest key is intentionally preserved for wire compatibility.Validation