Repository navigation
fix(cli): cloud render uses the composition's data-fps and skips unused heavy files - #6895
Conversation
There was a problem hiding this comment.
Verdict: REQUEST CHANGES · 1 blocker · 0 important · 0 nits · head 4c90fba2
- blocker — PR body has no
fails without the fix:line. "(fail on main)" is noted, but name the tests on that line, e.g.render.test.ts›resolveCloudFpsArg› "reads the root data-fps when --fps is absent" andoffload.test.ts› "leaves heavy files nothing references out of the archive, but keeps one a variable names".
Code reads correct otherwise; one approval after the body fix is fine from my side.
Scope
Read the full diff: cloud/render.ts (resolveCloudFpsArg via resolveDefaultFpsArg, fps parsed after project resolve, variables threaded into offload), cloud/offload.ts (dropUnusedHeavyFiles: referenced / ≥5 MB / script-or-text mention / --variables basename), tests. CI/CodeQL/Windows/preview-regression still running at review time.
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 0 nits · 4c90fba2 → 47a27539
1 resolved, 0 open, 0 new. The fails without the fix: line now names the tests. The new commit drops two doc comments and makes resolveCloudFpsArg read the directory from resolveProject; an invalid directory now fails at the same error box, just before --variables parsing. At review time, CI, CodeQL, Windows and preview-regression were still running; Comments passed.
What
hyperframes cloud rendernow renders at the composition's rootdata-fpswhen--fpsis not passed, and no longer uploads large working files nothing uses.Why
A 24 fps animated film rendered at 30 fps unless
--fps 24was passed by hand. Separately, motion guides and plates left inassets/pushed the upload zip past the 200 MB limit even though the composition never used them.How
resolveCloudFpsArgreusesresolveDefaultFpsArg, the same owner localrenderuses. A fractionaldata-fps(29.97) is left to the server default because the cloud API takes whole rates.offloadHeavyMediadrops files of 5 MB or more that no reference points at, that no script or file mentions by name, and that no--variablesvalue names. Smaller files and anything referenced are untouched.Test plan
--variablesis keptfails without the fix:
render.test.ts›resolveCloudFpsArg› "reads the root data-fps when --fps is absent", "lets an explicit --fps win", "leaves the server default when data-fps is absent or fractional";offload.test.ts› "leaves heavy files nothing references out of the archive, but keeps one a variable names", "keeps a heavy file only a --variables value names, and drops the one nothing names", "prepares a nested entry's GIF from the file next to it, as the renderer resolves it" (6 failed on the unfixed source)