Repository navigation
revert(engine): late-starting videos play to their last frame - #6746
Merged
Merged
Conversation
Reverts #6736. Its end-of-clip read fails intermittently on Windows, and the fallback then expects frames past the clip's end.
Contributor
Edit accuracy: accurate 271 (base branch 271), smooth 139 of thoseThe gate passes. Quarantined, measured but not gated (0) |
![heygengenesis[bot]](https://avatars.githubusercontent.com/in/2913576?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 0 nits · head c1a3aba1
This is an exact revert. The head's tree matches #6736's parent (the compare shows no file differences), and main has not moved past 22b53c01. Main's red check is the one the body names: Tests on windows-latest: engine-cli on 22b53c01 fails streamStartOffset.test.ts for fragment-cut.mp4 (3.541667 vs 3.375) and late.webm (4.04 vs 3.52). On this head every Actions run is green, including all Tests on windows-latest shards.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reverts #6736 (late-starting videos play to their last frame).
Why
On Windows the end-of-clip read #6736 added fails intermittently. When it fails, the playable end falls back to the clip's start plus ffprobe's duration, which runs past the last frame for fragmented MP4 and Matroska. A render then expects frames that do not exist. The required
Tests on windows-latest: engine-clicheck caught it: it is red on main since the merge (fragmented MP4 3.54 s against 3.375 s, late WebM 4.04 s against 3.52 s), after passing once at the PR head on the same FFmpeg build.Related work
Reverts #6736. The change comes back with the read's failure surfaced and a fallback that cannot run past the clip's end, once the Windows cause is known.
How
git revertof the squash commit; no other changes.Test plan
fails without the fix:
Tests on windows-latest: engine-clion main (streamStartOffset.test.ts, fragmented MP4 and late WebM rows). With this revert those rows are gone and the check should be green on this PR.