Repository navigation
refactor(engine): late-start measurement reads from names, not comments - #6744
miguel-heygen wants to merge 1 commit into
Conversation
Edit accuracy: accurate 271 (base branch 271), smooth 110 of thoseThe gate passes. Quarantined, measured but not gated (0) Unstable (3)
|
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 0 nits · 6b7fad08
The behaviour is the same: startsLate and lastPacket take the place of the inline condition and last, and only comments are removed. Comments (the ratchet) and CI pass.
Required Tests on windows-latest is red, but this PR didn't cause it. streamStartOffset.test.ts:389 (fragment-cut.mp4 3.54 vs 3.375, late.webm 4.04 vs 3.52) fails the same way on main at the merge base 22b53c0 (#6736, run 40873362926). The other failure, autoUpdate.test.ts in cli, passes on main and is unrelated, so it looks like a flake. This PR can't merge until main's Windows late-start measurement is fixed or an admin merges it.
What
The late-start measurement in
extractMediaMetadatacarries its meaning in names (startsLate,lastPacket) instead of four comment lines. No behaviour change.Why
The change that measures late-starting videos to their last packet raised
packages/engine/src/utils/ffprobe.ts's comment share from 13.5% to 13.7%, which the comment ratchet refuses. It merged with that check red; this brings the file back under its share.Related work
Refs #6736.
How
Drops the doc line on
resolvePlayableVideoDurationand the three-line comment above the late-start read. The reasoning (ffprobe's durations do not all run from the first frame in Matroska and fragmented MP4; a failed read keeps ffprobe's duration) is in #6736's description.Test plan
comment-ratchet.mjsagainst the merge base: clean.streamStartOffset.test.ts: 24 of 24, 3 runs in a row; engine frame extractor and ffprobe suites: 410 passed, 1 skipped.