Repository navigation
fix(studio): give the prompt preview editor an accessible name - #6450
Merged
Merged
Conversation
Co-authored-by: lorenzozanee <wyz0707@proton.me>
1 of 3 tasks
Contributor
Edit accuracy: accurate 271 (base branch 271), smooth 133 of thoseThe gate passes. Quarantined, measured but not gated (0) Unstable (2)
|
![heygengenesis[bot]](https://avatars.githubusercontent.com/in/2913576?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 0 nits · fa50e82a
Scope
Read both files. The textarea had no <label> and no aria-labelledby, so aria-label="Prompt" is the only name it gets, and the dialog's Ask agent: <title> label is unchanged. The newest CI and PR captures runs on this head passed. The earlier PR captures failures came before the body edits.
SanHsien
added a commit
to SanHsien/hyperframes
that referenced
this pull request
Oct 26, 2026
Brings in 10 upstream commits (ad4d3fa..15367a9): heygen-com#6425, heygen-com#6427, heygen-com#6429, heygen-com#6431, heygen-com#6436, heygen-com#6432, heygen-com#6453, heygen-com#6457, heygen-com#6450, heygen-com#6451. One conflict, packages/core/src/compiler/compositionScoping.ts (heygen-com#6436). This fork passes authored composition code to Function() as a JSON string literal, so upstream's markers around the raw source would sit outside the text its page-side scan reads and the fix would silently not apply: the wrapper's own __timelines use would make every composition look able to register a timeline. The markers go inside the literal instead, begin marker on the first source line so error line numbers do not shift. The pageBuild goldens change only by those two marker comments. A new engine test runs upstream's scan on this fork's real wrapper output and fails without the markers. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The prompt editor in the catalog's "Ask agent" modal gets
aria-label="Prompt", so screen readers announce it by name instead of reading the whole prompt text.Why
Fixes #4384. Re-lands #4398 by @lorenzozanee, closed after it went idle with one stale test string; the dialog label is now
Ask agent: <title>, and the test expects that.Before
After
Test plan
PromptPreviewModal.test.tsx(from the original PR, label string updated): 1/1, 3 runs. With main'sPromptPreviewModal.tsxrestored, it fails.Why under 100 lines
It re-lands one outside contributor's fix with their co-author credit and its own captures; bundling it with other re-lands would reset an approved review for no gain.