Repository navigation
fix(cli): hide the Windows console for the port lookup and clipboard - #6449
Merged
Merged
Conversation
Co-authored-by: lorenzozanee <lorenzozanee@users.noreply.github.com>
1 of 3 tasks
Contributor
Edit accuracy: accurate 271 (base branch 271), smooth 169 of thoseThe gate passes. Quarantined, measured but not gated (0) |
![heygengenesis[bot]](https://avatars.githubusercontent.com/in/2913576?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 0 nits · head 6db421f4
windowsHide: true is now on every spawn in portUtils.ts and clipboard.ts that can run on Windows (netstat, the where probe, and the clip.exe copy). Main's stdio/timeout options are kept. CI is green on this head.
— Genesis
SanHsien
added a commit
to SanHsien/hyperframes
that referenced
this pull request
Oct 26, 2026
Merge 20 more upstream commits (acd0bc3..ad4d3fa, v0.8.205: heygen-com#6403, heygen-com#6363, heygen-com#6209, heygen-com#6395, heygen-com#6424, heygen-com#6426, heygen-com#6442, heygen-com#6430, heygen-com#6402, heygen-com#6435, heygen-com#6439, heygen-com#6449, heygen-com#5436, heygen-com#6455 and docs). No conflicts. Record the 11 open PRs heygen-com#6440-heygen-com#6458 and issue heygen-com#6443 in docs/DECISIONS.md (none adopted), re-check the earlier open PRs, and advance the commit watermark to ad4d3fa, the PR watermark to heygen-com#6458 and the issue watermark to heygen-com#6443. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The CLI's Windows port lookup (
netstatinserver/portUtils.ts) and the clipboard provider probe and copy (utils/clipboard.ts) now passwindowsHide: true, so they no longer flash a console window on Windows.Why
Re-lands #3960 by @lorenzozanee, which was approved but closed after it went stale and conflicted with main. The telemetry spawn from that PR has since landed on main on its own, so this carries the two remaining sites and their tests.
How
One option on each spawn call. The clipboard conflict with main's newer
stdio/timeoutoptions is resolved by keeping both.Test plan
portUtils.windowsHide.test.tsandclipboard.windowsHide.test.ts(from the original PR): 2/2, 3 runs. With main'sportUtils.tsandclipboard.tsrestored, both fail.Why under 100 lines of source: it is two call-site options; the rest is the tests.