Skip to content

codegen: resync cloud client from EF ec4d7109 - #6243

Closed
heygen-rui-bot wants to merge 1 commit into
mainfrom
sync/hyperframes-codegen-ec4d7109
Closed

heygen-rui-bot wants to merge 1 commit into
mainfrom
sync/hyperframes-codegen-ec4d7109

Conversation

@heygen-rui-bot

Copy link
Copy Markdown
Collaborator

Auto-generated PR: the HyperFrames cloud-render OpenAPI surface in experiment-framework changed. This PR regenerates the typed client in packages/cli/src/cloud/_gen/.

Generated by scripts/generate_hyperframes_cli_client.py.

Source commit: ec4d71097dc5163a98d63d76dcb11bb1097650ea
Triggered by: https://github.com/heygen-com/experiment-framework/commit/ec4d71097dc5163a98d63d76dcb11bb1097650ea

@heygen-rui-bot

Copy link
Copy Markdown
Collaborator Author

Superseded by sync/hyperframes-codegen-02288cbb from EF commit 02288cbbca2f3e282c3d7aca918a5781d154ea88.

@miguel-heygen miguel-heygen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same regeneration as #6221 against a newer upstream commit, and it hits the same two required failures:

  • It removes page_motion_blur from CreateHyperframesRenderRequest, but packages/cli/src/commands/cloud/render.ts:814 and :843 still use it for cloud render --page-motion-blur. Typecheck fails on exactly those lines. The field was added to the generated file by hand in #6087 so each resync will keep dropping it until the generated schema declares it. Patching _gen/types.ts by hand again would only last until the next sync.
  • "Semantic PR title" rejects codegen as a type. Using chore(cli): resync cloud client from <sha> in the generator's title would fix this for every future resync.

Since the bot keeps producing resyncs that can't merge, a cheap guard would help: run the CLI typecheck in the generation job before opening the PR, so a schema gap like this shows up there and not as another red PR.

The failure_code doc change is fine. The CLI never reads failure_code, and it already prints failure_message, which the new doc says carries the usage limit's own message, so users see the right text without any CLI change.

Reviewed at 7e8e70e.

Verdict: REQUEST_CHANGES
Reasoning: Two required checks are red, and merging would break the CLI typecheck because the regen drops a field the cloud render command still sends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants