Repository navigation
fix(skills): storyboard stills leave the film as it was until the go - #5982
Merged
Merged
Conversation
somanshreddy
approved these changes
Oct 20, 2026
somanshreddy
left a comment
Contributor
There was a problem hiding this comment.
Approving at d6c676aa. Skill text only.
What I checked:
- The film/posed round-trip is consistent at every step.
- Before the first pose,
index.htmlis copied toboards/.film.html(§ 1 step 1). - After snapshotting, the posed
index.htmlis copied to.posed.htmland the film is restored (step 4). The preview therefore plays the film, not held stills, while the board waits. - A redo loads
.posed.html, re-poses, and goes back through step 4, so.posed.htmlalways holds the latest approved poses. - On go, the poses are restored before animating (step 6).
- Before the first pose,
- Cross-references. The renumbering is followed through:
review-loop.md's "§ 1 step 4" → "step 5", and step 2's "(step 4)" → "(step 5)". - No CLI change. The recipe uses only
snapshotwith existing flags, so the skill can ship on merge without skewing against a pinned Desktop CLI.skills-manifest.jsonhashes are updated for both edited skills.
Non-blocking: during the review stop, any edit to the film's index.html (say, an agent fixing audio while waiting) is overwritten when a redo copies .posed.html over it. That's harmless in this flow, since nothing else edits the film until go, but a line saying "change nothing in index.html while the board waits" would make it explicit.
— Somu
miguel-heygen
enabled auto-merge
October 20, 2026 22:40
miguel-heygen
added a commit
that referenced
this pull request
Oct 20, 2026
miguel-heygen
added a commit
that referenced
this pull request
Oct 21, 2026
miguel-heygen
added a commit
that referenced
this pull request
Oct 21, 2026
miguel-heygen
added a commit
that referenced
this pull request
Oct 21, 2026
prenom6548
pushed a commit
to prenom6548/hyperframes
that referenced
this pull request
Oct 21, 2026
* chore: release v0.8.182 * chore: list heygen-com#5953 in the v0.8.182 notes * chore: add heygen-com#5843, heygen-com#5932 and heygen-com#5945 to the v0.8.182 notes * chore: add heygen-com#5923, heygen-com#5943, heygen-com#5956, heygen-com#5960, heygen-com#5961, heygen-com#5963, heygen-com#5964 and heygen-com#5966 to the v0.8.182 notes * chore: add heygen-com#5972, heygen-com#5977, heygen-com#5981 and heygen-com#5982 to the v0.8.182 notes * chore: add the 13 PRs merged since the last refresh to the v0.8.182 notes * chore: add heygen-com#6003, heygen-com#6005 and heygen-com#5579 to the v0.8.182 notes * chore: add heygen-com#6006 to the v0.8.182 notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The storyboard recipe posed every still in the root
index.html(snapshot renders only that file) and never put the film back, so after a storyboard the preview played the held stills as a slideshow while the person was still deciding.The recipe now keeps the film as it was until the go:
index.htmltoboards/.film.html.boards/.posed.htmland copyboards/.film.htmlback overindex.html.boards/.posed.htmland put the film back again; the go copiesboards/.posed.htmloverindex.htmland animates from there.review-loop.mdpoints at the redo step by number, now step 5. The copies sit underboards/as dot files, outside whathyperframes lintreads (the root HTML files andcompositions/).skills-manifest.jsonis regenerated by the pre-commit hook.What I did NOT exercise
A model run following the new recipe end to end; this is skill text only.