Skip to content

fix(skills): storyboard stills leave the film as it was until the go - #5982

Merged
miguel-heygen merged 1 commit into
mainfrom
fix/storyboard-recipe-film-back
Oct 20, 2026
Merged

miguel-heygen merged 1 commit into
mainfrom
fix/storyboard-recipe-film-back

Conversation

@miguel-heygen

Copy link
Copy Markdown
Collaborator

What changes

The storyboard recipe posed every still in the root index.html (snapshot renders only that file) and never put the film back, so after a storyboard the preview played the held stills as a slideshow while the person was still deciding.

The recipe now keeps the film as it was until the go:

  1. Before the first pose, copy index.html to boards/.film.html.
  2. After the stills and the board page, keep the posed composition as boards/.posed.html and copy boards/.film.html back over index.html.
  3. Notes on a frame re-pose from boards/.posed.html and put the film back again; the go copies boards/.posed.html over index.html and animates from there.

review-loop.md points at the redo step by number, now step 5. The copies sit under boards/ as dot files, outside what hyperframes lint reads (the root HTML files and compositions/). skills-manifest.json is regenerated by the pre-commit hook.

What I did NOT exercise

A model run following the new recipe end to end; this is skill text only.

@somanshreddy somanshreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at d6c676aa. Skill text only.

What I checked:

  • The film/posed round-trip is consistent at every step.
    • Before the first pose, index.html is copied to boards/.film.html (§ 1 step 1).
    • After snapshotting, the posed index.html is copied to .posed.html and the film is restored (step 4). The preview therefore plays the film, not held stills, while the board waits.
    • A redo loads .posed.html, re-poses, and goes back through step 4, so .posed.html always holds the latest approved poses.
    • On go, the poses are restored before animating (step 6).
  • Cross-references. The renumbering is followed through: review-loop.md's "§ 1 step 4" → "step 5", and step 2's "(step 4)" → "(step 5)".
  • No CLI change. The recipe uses only snapshot with existing flags, so the skill can ship on merge without skewing against a pinned Desktop CLI. skills-manifest.json hashes are updated for both edited skills.

Non-blocking: during the review stop, any edit to the film's index.html (say, an agent fixing audio while waiting) is overwritten when a redo copies .posed.html over it. That's harmless in this flow, since nothing else edits the film until go, but a line saying "change nothing in index.html while the board waits" would make it explicit.

— Somu

@miguel-heygen
miguel-heygen added this pull request to the merge queue Oct 20, 2026
Merged via the queue into main with commit 6590d56 Oct 20, 2026
56 of 57 checks passed
@miguel-heygen
miguel-heygen deleted the fix/storyboard-recipe-film-back branch October 20, 2026 22:47
prenom6548 pushed a commit to prenom6548/hyperframes that referenced this pull request Oct 21, 2026
* chore: release v0.8.182

* chore: list heygen-com#5953 in the v0.8.182 notes

* chore: add heygen-com#5843, heygen-com#5932 and heygen-com#5945 to the v0.8.182 notes

* chore: add heygen-com#5923, heygen-com#5943, heygen-com#5956, heygen-com#5960, heygen-com#5961, heygen-com#5963, heygen-com#5964 and heygen-com#5966 to the v0.8.182 notes

* chore: add heygen-com#5972, heygen-com#5977, heygen-com#5981 and heygen-com#5982 to the v0.8.182 notes

* chore: add the 13 PRs merged since the last refresh to the v0.8.182 notes

* chore: add heygen-com#6003, heygen-com#6005 and heygen-com#5579 to the v0.8.182 notes

* chore: add heygen-com#6006 to the v0.8.182 notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants