Repository navigation
Conversation
Collaborator
|
Thanks for tracking this down. The diagnosis was right for the code it targeted, but that code no longer exists on main. #5651 ( Need: no, the target was removed by #5651. Size: ok. Reuse: n/a. Simpler: n/a. — Rames |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
brandFontFaces(captions.mjs in faceless-explainer, product-launch-video, pr-to-video) now declares each per-script subset file as its own@font-facewith the matchingunicode-range.Why
Google Fonts / Fontsource ship a face as per-script files (
source-serif-4-cyrillic.woff2,source-serif-4-latin.woff2). The dedup key was family+weight+style, so only the alphabetically first file survived. In a Russian explainer the captions got only the Cyrillic subset, and every Latin word and digit fell back to a system font.Related work
None found.
How
The subset is read from the filename (latin, latin-ext, cyrillic, cyrillic-ext, greek, greek-ext, vietnamese) and added to the dedup key. Ranges are copied from the Google Fonts CSS. If the family name itself contains the subset word, the file is not treated as a subset.
Test plan
build-frame-subsets.test.mjscovers all three workflows. The new tests fail onmain(3 fail) and pass with the fix;node --teston that file plus the threecaptions.test.mjs: 116 pass.