Skip to content

fix(lint): add fix hints to the variables-entry and CSS parse findings - #5447

Merged
miguel-heygen merged 1 commit into
heygen-com:mainfrom
Muhtasim-Munif-Fahim:fix/lint-missing-fix-hints
Oct 26, 2026
Merged

miguel-heygen merged 1 commit into
heygen-com:mainfrom
Muhtasim-Munif-Fahim:fix/lint-missing-fix-hints

Conversation

@Muhtasim-Munif-Fahim

Copy link
Copy Markdown

Summary

Three lint findings were the only ones without a fixHint, so lint and check showed the message with no suggestion of what to change. Each one now has a short, concrete hint in the style of the neighbouring rules:

  • invalid_composition_variables_declaration, when an entry is not an object (packages/lint/src/rules/composition.ts): shows the shape of a valid entry, {"id":"title","type":"string","label":"Title","default":"Hello"}.
  • invalid_composition_variables_declaration, when an entry is missing or has an invalid id/type/label/default: names the entry index and shows the same example shape.
  • css_parse_error (packages/lint/src/rules/core.ts): points at the reported line and the usual causes (an unclosed brace, quote or comment, or a missing semicolon).

Messages, codes and severities are unchanged.

Closes #5392

Verification

  • The existing tests for these codes now assert the hint is present, and there is a new test for the "entry is not an object" branch. Without the source change, those 4 tests fail.
  • bun run --cwd packages/lint test: 20 files, 908 tests passed.
  • oxfmt --check and oxlint on packages/lint/src/rules/ are clean, and tsc --noEmit passes in packages/lint.

AI assistance was used to help write the patch and run tests; I reviewed the change.

@jrusso1020 jrusso1020 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at 73d4fb36. Thanks!

It adds a fixHint to all three findings from #5392, the two invalid_composition_variables_declaration branches and css_parse_error, and changes nothing else.

  • I checked the CSS hint's causes against PostCSS on malformed CSS: an unclosed brace, quote or comment, and a missing semicolon all fail to parse there.
  • The rule tests pass, and the full lint suite passes 908/908. With the source change reverted, 4 of the new assertions fail.
  • Merges cleanly with main.

Small optional follow-up: the existing "checks a declaration on the composition root too" test doesn't assert the fixHint yet. The issue's acceptance criteria ask for that, so it's worth one more line.

— Rames

@jrusso1020

Copy link
Copy Markdown
Collaborator

Thanks for this! It's approved and CI is green, but main only accepts signed commits, and your commit 73d4fb36 isn't signed, so it can't merge yet.

Quickest fix with an SSH key you already use for GitHub:

git config --global gpg.format ssh
git config --global user.signingkey ~/.ssh/id_ed25519.pub   # your public key
git config --global commit.gpgsign true
git commit --amend --no-edit -S
git push --force-with-lease

Also add that same key to GitHub as a Signing key (Settings → SSH and GPG keys → New SSH key → Key type: Signing key), and make sure the commit's email is a verified email on your account. Docs: Signing commits and Telling Git about your signing key.

Once the commit shows Verified, we'll re-approve and merge.

— Rames

auto-merge was automatically disabled October 24, 2026 08:24

Head branch was pushed to by a user without write access

@miguel-heygen miguel-heygen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked at fdf8d59. The three hints land where the findings are raised (composition.ts for both variables-entry branches, core.ts for css_parse_error), and each is pinned by a test that reads the hint.

I ran src/rules/composition.test.ts and src/rules/core.test.ts: 358 passed. With composition.ts and core.ts put back to the merge base, 4 of them fail, so the tests guard the change.

Verdict: APPROVE
Reasoning: small, scoped to the issue, tests fail without the change, CI green.

@miguel-heygen
miguel-heygen added this pull request to the merge queue Oct 26, 2026
Merged via the queue into heygen-com:main with commit 64cb655 Oct 26, 2026
66 checks passed
SanHsien added a commit to SanHsien/hyperframes that referenced this pull request Oct 26, 2026
Merge 8 upstream commits (85dcc19..7d6c02f: heygen-com#6418, heygen-com#5273, heygen-com#6245, heygen-com#5593,
heygen-com#5447, heygen-com#6415, heygen-com#6373, heygen-com#6375). Keep the fork's Windows-only ci.yml. For
cancellableProcess.ts take upstream's heygen-com#5273, which supersedes the fork's own
744a620 port (same StringDecoder design, but the output limit counts raw
bytes). Record the batch in docs/DECISIONS.md, mark heygen-com#6373/heygen-com#6375/heygen-com#6415/heygen-com#6418
as merged, and advance the commit watermark to 7d6c02f.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lint: add fix hints to invalid_composition_variables_declaration and css_parse_error

3 participants