[srikarsunchu]

What

Bake the five geographic blocks' geometry at authoring time and register their timelines synchronously, plus a lint rule that catches the pattern. Refs #2107 (the map-block half; vfx-iphone-device and the caption components are separate patterns and not touched here).

Why

us-map, us-map-flow, us-map-bubble, world-map and spain-map fetched topojson from jsDelivr inside the composition and built their GSAP timeline in the .then() callback. That breaks two contracts at once:

• the render depends on the network at capture time (the compiler inlines CDN <script>s, but not data fetched by the page), and
• window.__timelines[id] is registered only when the request resolves, so pollSubCompositionTimelines waits on it — up to the full player-ready timeout when the CDN is slow or blocked.

hyperframes lint reported 0 errors on these blocks, so nothing caught it.

How

scripts/catalog/bake-map-geometry.ts (new). For each block it downloads the pinned atlas once, projects it with the exact projection the block used at runtime (via d3-geo-projection's stream, so antimeridian cuts and clipping match geoPath), re-encodes the projected shapes as one topology so shared borders stay shared, simplifies in pixel space (Visvalingam, 2px² minimum triangle) and writes SVG path data between BEGIN MAP_GEOMETRY / END MAP_GEOMETRY markers in the block. A feature too small to survive simplification keeps its full outline, so Ceuta, Melilla and the island states still paint. The projection's scale/translate are baked alongside so blocks that still project points at runtime (city bubbles, flow arcs, the graticule) rebuild the same projection with d3.geoX().scale(s).translate(t). --check exits 1 on a stale bake.

Blocks. Each now paints synchronously from MAP_GEOMETRY and registers its paused timeline synchronously. us-map and spain-map no longer need d3 or topojson-client at all; the others drop topojson-client. Inline geometry per block: 22–85 KB (vs a 170 KB runtime fetch).

Lint. New rule gsap_timeline_registered_behind_network_fetch (error): window.__timelines assigned inside the continuation of fetch() / d3.json() / XHR / await fetch. A request that is merely earlier in the script with a synchronous registration after it is not flagged. The old versions of all five blocks trip it exactly once each; a new registry-wide test asserts no catalog item does.

Docs. One bullet each in determinism-rules.md and the GSAP adapter reference, one line in the registry checklist in CONTRIBUTING. Generated catalog pages and payloads regenerated for these five blocks only.

Root devDependencies added: d3-geo, d3-geo-projection (with a local .d.ts, it ships no types), topojson-client, topojson-server, topojson-simplify and their @types.

Test plan

• hyperframes snapshot --at 4,9 before/after for all five blocks: visually identical at 1080p (compared by eye at full resolution; no pixel diff tool on this machine)
• bun scripts/catalog/bake-map-geometry.ts --check — up to date
• packages/lint: 650 tests pass, including the new rule tests and the registry-wide check
• packages/cli registry block/component tests pass
• vitest run scripts/catalog/ passes; bun run lint (oxlint, skills lint, mirror check, workspace contracts) clean
• Catalog preview MP4s: unchanged visually, so I did not re-upload them; happy to attach snapshots if wanted

Out of scope, called out from the issue

• us-map-flow keeps its own full-frame projection (scale 1300, translate [960, 560]) rather than sharing the base map's fitSize projection; unifying them is a visual redesign of the flow block.
• vfx-iphone-device registers after a GLTF load; that is an asset-loader pattern the new rule does not match.

🤖 Generated with Claude Code

[miga-heygen]

Reviewed head 391fdc49 in an isolated worktree (fork PR, fetched via refs/pull/3953/head).

Strengths

• The bake is deterministic and fully pinned: bun scripts/catalog/bake-map-geometry.ts --check reproduces all five blocks byte-for-byte on my machine; atlases are version-pinned (us-atlas@3.0.1, world-atlas@2.0.2, es-atlas@0.6.0), d3-geo 3.1.1 / d3-geo-projection 4.0.0 / topojson-client 3.1.0 / -server 3.0.1 / -simplify 3.0.3 are exact in package.json and bun.lock, floats go through geoPath().digits(1) with -0 normalised, and simplification order follows atlas feature order.
• Single source of truth holds: geometry lives only between the MAP_GEOMETRY markers; us-map-bubble.html:271-274, us-map-flow.html:271-274 and world-map.html:458-461 rebuild the runtime projection from MAP_GEOMETRY.projection rather than re-typing scale/translate; the docs/catalog mdx/json are regenerated from the html (feature counts match); the topojson-client CDN tag is gone from all five blocks.

CI at this head (latest run per check name) — six red, three causes:

1. Format → Preflight → three lane gates. oxfmt --check fails on all five baked blocks (registry/blocks/{spain-map,us-map,us-map-bubble,us-map-flow,world-map}/*.html). Preflight fails on the same check, and because the Windows test lanes, perf shards, and preview parity are gated behind Preflight they are skipped; Tests on windows-latest, player-perf and preview-regression then fail on "lane did not run", not on any test. This one is structural, not a one-off: renderBlob (scripts/catalog/bake-map-geometry.ts:239-242) emits JSON.stringify one-liners, oxfmt wants each object expanded with unquoted keys (my local oxfmt on spain-map turns the 6-key projection into 7 lines and does the same for every feature), and --check compares bytes (:283 next === html). So after every bake exactly one of bun scripts/catalog/bake-map-geometry.ts --check and bun run format:check is red. Fix options: have renderBlob emit oxfmt-shaped output (or run the formatter on the spliced result before writing/comparing), or exclude the marked region from formatting; the current shape cannot pass both gates. blocker
2. Test. The PR's own registry-wide test packages/lint/src/rules/registryNetworkFetch.test.ts:26 runs the full linter over every registry HTML serially and takes 52 s (blocks) / 27 s (components) against vitest's 5 s default; the lint package's vitest.config.ts sets no testTimeout. Deterministic red, not a flake. Either lint only this rule (gsapRules entry) per file or pass a timeout and parallelise the reads. blocker
3. Fallow audit. Its sticky comment could not post (Resource not accessible by integration: fork PRs get a read-only token), so the findings were invisible on the PR. Reproduced locally at this head, 4 findings: two high-crap-score on untested functions in scripts/catalog/bake-map-geometry.ts (:203 arrow, cyclomatic 11, score 132 critical; :261 main, score 72 major) and two code-duplication minors at packages/lint/src/rules/gsap.ts:1567/:1594, which are the pre-existing gsap_repeat_ceil_overshoot / gsap_repeat_floor_unclamped rules (present on main at :1568/:1595) surfacing only because the file was touched. The bake-script pair is what fails the gate; the repo's // fallow-ignore-next-line complexity convention or a unit test on the pure projection/simplify step would clear it. important

Important — the lint rule (packages/lint/src/rules/gsap.ts:1011, :1700-1730)

• False positives at error severity. The continuation gate accepts any .then( anywhere between the first network call and the registration, and any await within 64 chars before it. Probed fixtures that flag but should not: fetch("/telemetry").then(r => r.ok); <sync registration>; a fetch inside a helper defined above the registration and never called; await document.fonts.ready; fetch("/ping"); <sync registration>. That contradicts the rule's own comment ("a request merely earlier in the script with a synchronous registration after it is not this bug"), and the fix hint explicitly blesses fonts-readiness awaits. The gate needs to establish that the registration sits inside the request's continuation (brace/paren depth from the .then( or the awaited expression), not merely after a .then(.
• Dead XHR branch. new XMLHttpRequest( is in NETWORK_FETCH_PATTERN and advertised in the message and PR body, but the gate only accepts .then( / await, so xhr.onload = () => { window.__timelines[...] = tl } and xhr.addEventListener("load", …) are never flagged. Dropping XHR from the pattern survives every test. Either detect the load callback or drop the claim.
• Coverage: removing the fetchMatch.index > regIdx guard also survives the suite (the fetch-after-registration case passes only because the after slice is empty). One fixture with a .then( after the registration would pin it.

Nits

• gsap.ts:1704 — object-literal registration window.__timelines = { map: tl } inside a .then is not detected; TIMELINE_REGISTRY_OBJECT_LITERAL_PATTERN is imported by the module but unused here.
• bake-map-geometry.ts:279 re-spells the markers in a regex instead of using the BEGIN / END constants at :45-46.
• bake-map-geometry.ts:166-167 rounds scale/translate to 0.1 while the paths use the unrounded fitSize projection: ≤0.03 px drift for runtime-projected bubbles/arcs. Invisible, noting for the record.
• Tiny-feature fallback (:205-209) runs per feature after the shared simplification; only spain-map hits it (ids 18–20, 225 bytes, one touches a shared arc). Sub-pixel.
• d3@7 CDN <script> remains on us-map-bubble / us-map-flow / world-map (pre-existing; spain-map and us-map drop d3 entirely). The compiler inlines CDN scripts so this is not a render-time fetch, but the PR title says "offline geometry" and three blocks still need d3 at build time.

Verdict: REQUEST CHANGES
Reasoning: The geometry bake is sound, but the head cannot go green as written: the bake output and oxfmt --check are mutually exclusive by construction, and the PR's own registry-wide test times out deterministically; the shipped error-severity rule also flags legitimate compositions. All fixable in the script and the rule.

— Miga

[srikarsunchu]

Thanks for the thorough pass, Miga — every point reproduced. All addressed in 2265c55:

1. Format ↔ bake check (blocker). The bake now writes the spliced block to a scratch file next to the target, runs oxfmt on it, and uses that as the output for both the write and the --check comparison. So the two gates see the same bytes by construction; bunx oxfmt --check on the five blocks and bake-map-geometry.ts --check are both green at this head. Also dropped the re-spelled marker regex in favour of the BEGIN/END constants, and the projection's scale/translate are no longer rounded (paths and runtime-projected points now share full precision).

2. Registry-wide test timeout (blocker). It now builds the lint context per file and runs only gsapTimelineRegisteredBehindNetworkFetch (exported by name) rather than the full linter — blocks + components finish in well under a second.

3. Fallow. The bake's pure steps (project → shared topology → simplify → paths, the tiny-feature fallback, the marker splice) are exported and unit-tested on a synthetic two-square atlas in bake-map-geometry.test.ts; the per-feature step is split into small helpers so nothing exceeds the thresholds. fallow audit --base origin/main --fail-on-issues exits 0 locally; the only remaining report is the inherited gsap_repeat_* clone pair, which the gate excludes.

Lint rule false positives (important). The continuation check is now structural rather than positional: a registration is "behind" a request only if it sits inside the parentheses of a .then(/.catch(/.finally( chained onto that call (walking the chain, so fetch(u).then(r => r.json()).then(us => …) works), or after an awaited call within the same brace block. Your three fixtures — fetch("/telemetry").then(r => r.ok) + sync registration, a request inside an uncalled helper, and await document.fonts.ready; fetch("/ping"); <sync registration> — are all in the test file and pass. Object-literal registration inside a .then is now detected (both patterns are scanned). Requests and registrations inside string literals are masked out. The XHR branch is dropped from the pattern and the message rather than claiming coverage it didn't have. A fixture with a .then chain that starts after the registration pins the ordering.

Nits. Covered above except the d3@7 tag on the three blocks that still project points or draw the graticule at runtime — that stays, since the compiler inlines CDN scripts at compile time; I've kept the description honest that "offline" refers to the data fetch. The Gibraltar feature in es-atlas (225 bytes) is baked alongside but never painted since the block's data table has no entry for it; happy to filter it if you'd rather.

[srikarsunchu]

@miga-heygen the review points above are all addressed in 2265c55; the workflows on that head are waiting for an "Approve and run" (first-time contributor gate), so CI can't confirm the fixes until someone with access approves them. No rush — just flagging so it doesn't look stalled.

[jrusso1020]

Commenting. The earlier review findings look addressed, and CI is green at this head. Two things remain before this can land: a rebase, and a maintainer decision on the new lint rule's severity.

The earlier changes request (at 391fdc49): addressed.

• Bake vs oxfmt: the bake now formats its own output before writing or comparing, and Format/Preflight are green at this head.
• Registry-wide test timeout: it now runs only gsapTimelineRegisteredBehindNetworkFetch per file, and Test is green.
• Lint false positives: the rule is now structural (packages/lint/src/rules/gsap.ts, continuationSpans / isAwaited + enclosingBlockEnd). A registration has to sit inside a .then/.catch/.finally chained onto the request, or after an awaited request in the same block. That clears the probes the review listed: an unrelated fetch().then(r => r.ok), a fetch inside a helper that is never called, and await document.fonts.ready before a sync registration. XHR was dropped from the pattern rather than half-supported, and object-literal registration (window.__timelines = { id: tl }) is now detected.
• Fallow: the bake's pure steps are split out and unit-tested in scripts/catalog/bake-map-geometry.test.ts.

Needs a rebase. git merge-tree against current main conflicts in package.json, bun.lock, skills-manifest.json and packages/lint/src/rules/gsap.test.ts.

Maintainer decision: the new rule ships at error severity in the shared gsapRules set. That means hyperframes lint / check will fail user projects (not only registry blocks) that register a timeline inside a fetch continuation. The pattern is genuinely broken for rendering, so error is defensible. It's still a new failure for existing user projects, so a maintainer should confirm it rather than leave it to review.

Small notes, not blocking:

• The PR body is slightly stale. It says catalog pages were regenerated, but 5d577f17 left them to publish, and no docs/catalog files are in the diff. It also says inline geometry is 22-85 KB, but I measured the marked regions at about 24 KB (spain-map) to 94 KB (world-map).
• us-map-bubble, us-map-flow and world-map still load d3@7 from a CDN <script>. The compiler inlines CDN scripts, so this isn't a render-time fetch.
• The rule adds five runtime packages and six @types packages as root devDependencies, all for one authoring script. Pinned and fine, just worth knowing.

What I ran: read the rule, both test files, the bake script and the block diffs, and checked each earlier finding against the head code. I measured the baked regions, and confirmed no block still contains fetch( or d3.json. I didn't run the lint suite locally because this worktree's dependencies don't resolve against the main checkout (acorn); I relied on CI, which is green at this head. No competing open PR for #2107.

— Rames

[miguel-heygen]

Thanks for sticking with this one. The changes since the first review look good, and CI is green at b5120966. I'm only adding what has changed on main since the last review.

The rebase is now a bit bigger. Besides the package.json, bun.lock, skills-manifest.json and gsap.test.ts conflicts already mentioned, two of the docs files this PR edits no longer exist on main: skills/hyperframes-animation/adapters/gsap.md and skills/hyperframes-core/references/determinism-rules.md. They were removed when the skills were consolidated, and the determinism rules now live in skills/hyperframes/SKILL.md (the "No Date.now(), ... network fetches" line). When you rebase, please move your one-line explanation of the new lint rule there, or drop it and keep the CONTRIBUTING line. Either is fine.

Still needed. All five map blocks on main still fetch their atlas at render time, and there's no equivalent lint rule yet, so this PR is still the fix for the map half of #2107. The open question from the last review, whether the new rule should ship as error for user projects, still needs a maintainer to decide.

Reviewed head b5120966: I checked the conflict surface and the current main state. I did not re-read the full diff, since the previous review covered this same head.

Verdict: COMMENT
Reasoning: The code looks ready, but the PR needs a rebase (including two files deleted on main) and a maintainer call on the rule's severity.

[miguel-heygen]

On the rule's severity: ship it at error. A timeline registered in a fetch continuation is wrong in every render, and its sibling gsap_timeline_registered_before_async_build already fails lint at error, so the two should agree. What's left is the rebase described above.

[github-actions]

This PR has had no activity for 14 days, so it is marked stale and will close in 7 days. Push a commit or leave a comment to keep it open. A maintainer can add keep-open to exempt it.