Repository navigation
fix(skills): default to non-.en whisper models to prevent silent translation - #186
Closed
vanceingalls wants to merge 1 commit into
Closed
vanceingalls wants to merge 1 commit into
vanceingalls wants to merge 1 commit into
Conversation
This was referenced Apr 1, 2026
Merged
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8 tasks
…slation .en models (small.en, medium.en) translate non-English audio into English instead of transcribing it. This silently destroys the original language. - Add non-negotiable language rule to captions skill - Update model tables to default to models without .en suffix Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vanceingalls
force-pushed
the
fix/whisper-multilingual-default
branch
from
April 2, 2026 05:30
47ee56a to
b025994
Compare
vanceingalls
force-pushed
the
vance/validate-command
branch
from
April 2, 2026 05:30
a321571 to
2917f6a
Compare
vanceingalls
marked this pull request as ready for review
April 2, 2026 05:31
4 tasks
Collaborator
Author
|
Folded into #175 (vance/whisper-improvements) |
vanceingalls
added a commit
that referenced
this pull request
Apr 2, 2026
…multilingual defaults (#175) ## Summary **Whisper improvements:** - Auto-detect language and switch from `.en` to multilingual model when needed - Detect speech onset in WAV to strip hallucinated words before speech begins - Merge whisper-cpp token fragments: contractions (`didn` + `'t` → `didn't`), split capitals (`C` + `aught` → `Caught`), dropped-g (`shin` + `in'` → `shinin'`) - Interpolate zero-duration word clusters for reliable karaoke timing **Captions skill updates (folded from #176):** - Rewrite script-to-style mapping as an energy detection table (high → low) with mandatory animation requirements: karaoke baseline, 2+ highlight techniques, kinetic exits - Replace `tl.call()` per-frame audio-reactive pattern with group-level GSAP tweens — read peak bass/treble for each group's time range and modulate entrance intensity at build time - Add transcript quality check with automatic retry rules (>20% music tokens = retry with larger model) - Add caption word structure lint rule (`.caption-group` + `<span>`) for studio editor compatibility **Multilingual defaults (folded from #186):** - Default whisper model changed from `small.en` to `small` to prevent silent translation of non-English audio - Added non-negotiable language rule to captions skill ## Test plan - [ ] `pnpm test` passes (contraction merging, fragment merging, zero-duration interpolation, speech onset) - [ ] Transcribe non-English audio — verify it transcribes in original language, not translates - [ ] Skill files render correctly, cross-references resolve - [ ] `dynamic-techniques.md` audio-reactive section uses `tl.to()`/`tl.set()` only, no `tl.call()` loops 🤖 Generated with [Claude Code](https://claude.com/claude-code)
dahans-msft2
pushed a commit
to dahans-msft2/hyperframes
that referenced
this pull request
Aug 6, 2026
…multilingual defaults (heygen-com#175) ## Summary **Whisper improvements:** - Auto-detect language and switch from `.en` to multilingual model when needed - Detect speech onset in WAV to strip hallucinated words before speech begins - Merge whisper-cpp token fragments: contractions (`didn` + `'t` → `didn't`), split capitals (`C` + `aught` → `Caught`), dropped-g (`shin` + `in'` → `shinin'`) - Interpolate zero-duration word clusters for reliable karaoke timing **Captions skill updates (folded from heygen-com#176):** - Rewrite script-to-style mapping as an energy detection table (high → low) with mandatory animation requirements: karaoke baseline, 2+ highlight techniques, kinetic exits - Replace `tl.call()` per-frame audio-reactive pattern with group-level GSAP tweens — read peak bass/treble for each group's time range and modulate entrance intensity at build time - Add transcript quality check with automatic retry rules (>20% music tokens = retry with larger model) - Add caption word structure lint rule (`.caption-group` + `<span>`) for studio editor compatibility **Multilingual defaults (folded from heygen-com#186):** - Default whisper model changed from `small.en` to `small` to prevent silent translation of non-English audio - Added non-negotiable language rule to captions skill ## Test plan - [ ] `pnpm test` passes (contraction merging, fragment merging, zero-duration interpolation, speech onset) - [ ] Transcribe non-English audio — verify it transcribes in original language, not translates - [ ] Skill files render correctly, cross-references resolve - [ ] `dynamic-techniques.md` audio-reactive section uses `tl.to()`/`tl.set()` only, no `tl.call()` loops 🤖 Generated with [Claude Code](https://claude.com/claude-code)
SanHsien
added a commit
to SanHsien/hyperframes
that referenced
this pull request
Oct 25, 2026
happy-dom ^20.9.0 升到 ^21.0.4（修 GHSA-834v-8h66-3h79），bun.lock 解析為 21.0.4。 測試端配合 21 的行為差異，沒有動產品程式：iframe 頁面載入改在 player、sdk、studio 的 vitest 設定開啟；inlineTextStyleRange、Menu、ShortcutsPanel、motion-signature、 manualOffsetDrag、NLEPreview.slowBoot 的測試調整環境設定或等待方式。 移除 dependabot 對 happy-dom 的 semver-major ignore；DECISIONS 記錄理由失效與 CodeQL 警示 heygen-com#186 至 heygen-com#193 以 false positive 駁回。 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.enwhisper models (small.en, medium.en) translate non-English audio into English instead of transcribing it, silently destroying the original language.enunless user explicitly says audio is English.envariants to multilingual models.enmodels directlyTest plan
hyperframes transcribeon non-English audio without specifying a model — should transcribe in original language, not translate🤖 Generated with Claude Code