Repository navigation
feat(core): shared gsapCascade helper + server-delete GSAP cascade (WS-E/2) - #1566
Closed
vanceingalls wants to merge 1 commit into
Closed
vanceingalls wants to merge 1 commit into
vanceingalls wants to merge 1 commit into
Conversation
…S-E/2) New packages/core/src/parsers/gsapCascade.ts lifts selectorMatchesId / collectSubtreeHfIds / cascadeRemoveAnimations / cascadeRemoveAnimationsFromDocument from mutate.ts (canonical subtree-aware impl), typed with minimal structural interfaces so it works for both linkedom and DOMParser elements. sdk/mutate.ts and core/htmlParser.ts now import from the core helper; their local duplicate cascade implementations are deleted. sourceMutation.removeElementFromHtml now collects the full subtree of data-hf-id values before element.remove(), then calls cascadeRemoveAnimationsFromDocument — eliminating dangling GSAP tweens when the studio server-delete route removes an element with animated children. Tests in sourceMutation.test.ts cover: leaf delete, parent-with-children (all subtree tweens stripped), positional renumbering (re-parse loop), non-gsap scripts untouched, element with no tweens. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Fallow audit reportFound 14 findings. Dead code (1)
Duplication (4)
Health (9)
Generated by fallow. |
Collaborator
|
Continuing this contribution in #3655, rebuilt on current main with regression coverage and attribution to this PR. Keeping this PR open until the successor lands. Thanks for the original fix. |
Collaborator
|
Closing as implemented in #3655, now merged. The successor preserves this contribution while updating it for current main and adding regression coverage. Thanks for the original fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Brief description of the change.
Why
Why is this change needed?
How
How was this implemented? Any notable design decisions?
Test plan
How was this tested?