Repository navigation
Use native Rust references instead of wrappers - #169
Merged
Merged
Conversation
boxdot
reviewed
Mar 4, 2020
boxdot
reviewed
Mar 4, 2020
Contributor
|
Is this still WIP? |
Collaborator
Author
|
A few things left to clean up, should finish this weekend |
VeaaC
commented
Mar 6, 2020
VeaaC
changed the title
VeaaC
force-pushed
the
simple_flat
branch
4 times, most recently
from
April 11, 2020 16:33
0e9a428 to
53784fc
Compare
Collaborator
Author
|
@boxdot ready for review |
boxdot
reviewed
Apr 13, 2020
boxdot
left a comment
boxdot
left a comment
Contributor
There was a problem hiding this comment.
There are still some clippy warning. But I think they are not that important and we can fix them after this is merged.
|
|
||
| /// Number of elements in the vector. | ||
| #[inline] | ||
| pub fn len(&self) -> usize { |
Contributor
There was a problem hiding this comment.
Any reason for removing this?
Collaborator
Author
There was a problem hiding this comment.
You get it for free from Deref<&[T]> (like most other slice functions I removed)
Note: This is a breaking change! Changes: * A struct transparently wraps a byte array of correct size * Instead of Ref/RefMute &Struct and &mut Struct are used * ArrayView is replaced by native slices * Archives store members with 'static lifetime, instead of constructing them all the time from pointers Signed-off-by: Christian Vetter <christian.vetter@here.com>
Signed-off-by: Christian Vetter <christian.vetter@here.com>
Signed-off-by: Christian Vetter <christian.vetter@here.com>
Signed-off-by: Christian Vetter <christian.vetter@here.com>
boxdot
approved these changes
Apr 15, 2020
Contributor
|
Impressive! |
This was referenced May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is a breaking change!
Changes: