This repository was archived by the owner on Oct 17, 2023. It is now read-only.
Repository navigation
Fix for issue #44 - #62
Merged
Merged
Conversation
Commit based on PR hellosign#50 that was never merged. Added code to incorporate functionality for attachments with signer requests
martinytodorov
suggested changes
Jan 2, 2020
martinytodorov
left a comment
martinytodorov
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding the attachments parameter. I left a few comments, mostly typos.
Co-Authored-By: Martin Todorov <martin.todorov@hellosign.com>
Co-Authored-By: Martin Todorov <martin.todorov@hellosign.com>
Co-Authored-By: Martin Todorov <martin.todorov@hellosign.com>
Co-Authored-By: Martin Todorov <martin.todorov@hellosign.com>
Contributor
Author
|
@martinytodorov - please verify updates. |
Commit based on PR hellosign#50 that was never merged. Added code to incorporate functionality for attachments with signer requests
# Conflicts: # hellosign_sdk/hsclient.py
Contributor
Author
|
Amended the commit and re-pushed @martinytodorov |
| @@ -0,0 +1,2441 @@ | |||
| from hellosign_sdk.utils import HSRequest, HSException, NoAuthMethod, HSAccessTokenAuth, HSFormat, api_resource, api_resource_list | |||
Contributor
There was a problem hiding this comment.
@oconnor-sn I think you accidentally added this file. I don't think it should be part of this PR. Can you please remove it.
Contributor
Author
There was a problem hiding this comment.
@martinytodorov - Thanks Martin - changes were made to hsclient.py which is why I added this file - please review and advise further.
Add in error
martinytodorov
suggested changes
Jan 14, 2020
Co-Authored-By: Martin Todorov <martin.todorov@hellosign.com>
Co-Authored-By: Martin Todorov <martin.todorov@hellosign.com>
|
|
||
| is_for_embedded_signing (bool): send_signature_request and send_signature_request_embedded share the same sending logic. To differenciate the two calls embedded requests are now flagged. | ||
|
|
||
| attachments (list of dict): A list of attachments, each with the following attributes:: |
Contributor
There was a problem hiding this comment.
Suggested change
| attachments (list of dict): A list of attachments, each with the following attributes:: | |
| attachments (list of dict): A list of attachments, each with the following attributes: |
Contributor
There was a problem hiding this comment.
Sorry I must have added an additional column.
|
|
||
| signing_options (dict, optional): Allows the requester to specify the types allowed for creating a signature. Defaults to account settings. | ||
|
|
||
| attachments (list of dict): A list of attachments, each with the following attributes:: |
Contributor
There was a problem hiding this comment.
Suggested change
| attachments (list of dict): A list of attachments, each with the following attributes:: | |
| attachments (list of dict): A list of attachments, each with the following attributes: |
Contributor
There was a problem hiding this comment.
Sorry I must have added an additional column.
Contributor
|
Hey @oconnor-sn I checked out the branch on my machine and made a few tests. I realized that there are couple of more things that need to be fixed.
Here's some tips you should follow when opening the PRs:
Let me know if you have any questions. |
Commit based on PR hellosign#50 that was never merged. Added code to incorporate functionality for attachments with signer requests
Commit based on PR hellosign#50 that was never merged. Added code to incorporate functionality for attachments with signer requests
Contributor
Author
|
@martinytodorov - anything outstanding on this PR? |
martinytodorov
approved these changes
Feb 6, 2020
| if (merge_fields is not None): | ||
| data.update(merge_fields_payload) | ||
| data = HSFormat.strip_none_values(data) | ||
| data.update(attachments_payload) |
Contributor
There was a problem hiding this comment.
Can we move this line with the rest of the updates above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit based on PR #50 that was never merged.
Added code to incorporate functionality for attachments with signer
requests