Repository navigation
fix(opencode): strip thinking blocks from compaction, guard orphaned boundaries - #268
Merged
jeonghun-jj-lee merged 1 commit intoAug 28, 2026
Merged
Conversation
…haned boundaries Fixes #267 — compaction fails with API error on Bedrock Claude models using extended thinking because reasoning blocks in the latest assistant message cannot be modified. Two independent fixes: 1. Add forCompaction option to toModelMessagesEffect that unconditionally downgrades reasoning blocks to plain text (regardless of model match), enforcing the spec invariant that reasoning does not survive compaction. Wire this option in the compaction caller. 2. Guard filterCompacted's second-phase reorder to require !msg.info.error on the summary-assistant, preventing an errored compaction from truncating pre-tail history (the 'context cleared' symptom).
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #267
Summary
Compaction fails with an API error on Bedrock Claude Opus 4.6 when extended thinking is enabled: the Anthropic API rejects requests where
thinking/redacted_thinkingblocks in the latest assistant message are modified. The failure path then incorrectly treats the errored compaction as a valid boundary, truncating the user's conversation history.Changes
Part A — Strip thinking blocks from compaction input
forCompactionoption totoModelMessagesEffect(consistent with existingstripMedia/toolOutputMaxCharsoptions)forCompaction: true, reasoning blocks are unconditionally downgraded to plain text regardless of model matchprocessCompaction)specs/v2/session.mdinvariant: reasoning does not survive compaction boundariesPart B — Guard orphaned compaction boundaries
!msg.info.errorcheck tofilterCompacted's second-phase summary lookupTesting
strips reasoning blocks when forCompaction is true, even for same modelerrored summary does not truncate pre-tail historymissing summary does not truncate pre-tail history