Repository navigation
docs(skills): deliberate — spec-design checks from the fluxonium-cz campaign - #2153
Draft
aarontrowbridge wants to merge 1 commit into
Draft
aarontrowbridge wants to merge 1 commit into
aarontrowbridge wants to merge 1 commit into
Conversation
…ritic-waived specs (defined estimators, falsifiable keys, nominal-case bars, units)
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
None filed yet — draft from the skills-integrity loop (finding
F-fcz-14). File an issue before marking ready.Description
deliberate: adds "Further checks from the fluxonium-cz campaign" to Spec-design checks: define every window/feature/space/estimator; a key must be able to fail (degrees of freedom, denominators, definitional keys); evaluate every bar at the nominal case; make counts/names/paths agree with the disk; cite the verifier line a convention must agree with; give every budget a unit and a legal value (amico spec reviewrejectedmax_solves: 0); bound reproduction steps by more than the clock.Evidence
Seven analysis-class specs approved on the mechanical gate alone (critic waived) surfaced nine defects in wave 1 (F-fcz-14) and more in later notes (D2a, D2b, H2c, B8, B9, B10, B11, G1, G1b, G2, H2d, A2).
Honesty flags
The
max_solves: 0rejection is the campaign's observation (not re-run against the currentamico). One campaign, so the checks are candidates, not banked doctrine; each is tagged with the note that produced it.Verification
Lint on this branch:
lint-skills: 40 skills, 0 error(s), 5 warning(s) — ok; noprivate-packagehits; skill tests 42/42.