Specify which whitespace definition is used for matchers #196

Activity

1. sf105

   added

   enhancement

   on Apr 3, 2018
2. sf105 commented on Apr 3, 2018

   

   sf105

   on Apr 3, 2018

   Member

   More actions

   This is a good point.
3. Harlan1997 commented on Apr 25, 2021

   

   Harlan1997

   on Apr 25, 2021

   More actions

   This is a good point.

   I would like to work with this issue. I have tried to expand equalToCompressingWhiteSpace by adding a property whiteSpaceType which is a enum type variable with 6 types of whitespace: space, tab, line feed, form feed, carriagereturn, mix(mix types above), and I modify the constructor and stripSpaces to strip string according to different types of whitespace. To prevent conflicts, I added 6 types of matcher generators, like public static Matcher<String> equalToCompressingSPACE(String expectedString){}.
4. Harlan1997

   added 2 commits that reference this issue on Apr 25, 2021

   enhancement on isuue hamcrest#196

   ...

   9495214

   update test according to issue hamcrest#196

   5c8878f
5. sf105 commented on Apr 25, 2021

   

   sf105

   on Apr 25, 2021

   Member

   More actions

   Interesting point. Another option would be to introduce a policy object for the kind of white space to be stripped, that would allow new combinations. With the current approach, you could stash the regex in the enum value, which would avoid the chained if statements (which should be a switch anyway).
6. Harlan1997

   added a commit that references this issue on Apr 26, 2021

   enhancement on issue hamcrest#196

   683a956
7. Harlan1997 commented on May 24, 2021

   

   Harlan1997

   on May 24, 2021

   More actions

   Interesting point. Another option would be to introduce a policy object for the kind of white space to be stripped, that would allow new combinations. With the current approach, you could stash the regex in the enum value, which would avoid the chained if statements (which should be a switch anyway).

   Thank you. I will have a try.