github doesn't add itself to the package list #21

Activity

1. randrescastaneda commented on Apr 26, 2022

   

   randrescastaneda

   on Apr 26, 2022

   More actions

   Did you use github to install github? Say, github install haghish/github. If you do, it works fine.

   

   @bquistorff
2. bquistorff commented on Apr 26, 2022

   

   bquistorff

   on Apr 26, 2022

   ContributorAuthor

   More actions

   No, I did a net install following the instructions).
3. randrescastaneda commented on Apr 29, 2022

   

   randrescastaneda

   on Apr 29, 2022

   More actions

   Right. The problem is that github version reads from file g/github.dta , which is updated with the subcommand githubdb add. This subcommand is executed inside github install right after the Stata package is installed using net install. One solution is suggest the following in the instructions

   net install github, from("https://haghish.github.io/github/")
   github install haghish/github

   or

   net install github, from("https://haghish.github.io/github/")
   githubdb add, address("haghish/github") username("haghish")  ///
   		              reponame("github") name("github")

   I know. It is overkill, but I don't see another way to solve it.
4. bquistorff commented on Apr 29, 2022

   

   bquistorff

   on Apr 29, 2022

   ContributorAuthor

   More actions

   If they are feasible, a few other options that don't require user changes could be:

   • github version has a special check for github.
   • github version (or any other command that depends on the info), first checks if it's listed in g/github.dta and if not, does the githubdb add.
5. mronkko commented on Sep 14, 2024

   

   mronkko

   on Sep 14, 2024

   More actions

   This is clearly a bug. If a user does not have github installed, they must use the "net install" method. But if this method is used, installing rcall fails unless the user realizes that they must install github twice for it to actually work.