Repository navigation
subtitle: add SubtitleFrame and subtitle codec contexts - #180
Merged
Merged
Conversation
Add a move-only SubtitleFrame/SubtitleRect API with text, ASS, bitmap and palette support. Add SubtitleDecoderContext and SubtitleEncoderContext that use the legacy FFmpeg subtitle API, and reject the unsupported send/receive/flush operations. Add subtitle decode/inspect and ASS generation examples, in-memory and fixture tests, and the avcpp-test-data fixtures integration. Fix Packet input padding required by the ASS muxer, and add av::wrap2sview, av::freep and av::strdup helpers.
Before FFmpeg 5.1 subtitle encoders provide only the legacy encode_sub callback and have neither encode2 nor receive_packet. Codec::canEncode() ignored it, so every subtitle encoder looked like a decoding-only codec and SubtitleEncoderContext construction failed with CodecInvalidDirection on FFmpeg 4.x, including the Ubuntu 22.04 CI jobs. Match the upstream av_codec_is_encoder() check and cover the direction of subtitle codecs with a version-independent test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a move-only SubtitleFrame/SubtitleRect API with text, ASS, bitmap and palette support. Add SubtitleDecoderContext and SubtitleEncoderContext that use the legacy FFmpeg subtitle API, and reject the unsupported send/receive/flush operations.
Add subtitle decode/inspect and ASS generation examples, in-memory and fixture tests, and the avcpp-test-data fixtures integration. Fix Packet input padding required by the ASS muxer, and add av::wrap2sview, av::freep and av::strdup helpers.
Fix #170