Skip to content

fix(groups): send iterable rules as lists - #56

Merged
kevinyun merged 2 commits into
mainfrom
dev
Nov 18, 2026
Merged

kevinyun merged 2 commits into
mainfrom
dev

Conversation

@kevinyun

Copy link
Copy Markdown
Contributor

Reward-group rules passed as an iterator or generator failed JSON encoding before the request. _body now converts them to lists; regression tests cover iterator, generator and tuple (sync + async).

🤖 Generated with Claude Code

Iterators and generators passed as reward-group rules failed JSON encoding
before the request. Materialize them in _body and add regression tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T08:05:19.356800Z fde27db PR opened
🔒 Security Review ✅ Completed 2026-11-18T08:06:14.947751Z fde27db PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kevinyun
kevinyun merged commit fcadd19 into main Nov 18, 2026
8 checks passed
@kevinyun
kevinyun deleted the dev branch November 18, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant