Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Windows Support - #35

Closed
marpaia wants to merge 1 commit into
graphql:masterfrom
marpaia:windows
Closed

marpaia wants to merge 1 commit into
graphql:masterfrom
marpaia:windows

Conversation

@marpaia

@marpaia marpaia commented Aug 24, 2016 •

Copy link
Copy Markdown

I had to make a few changes to CMakeLists.txt in order to get libgraphqlparser to build and install on Windows 10. I haven't explicitly tested this on *nix, but the travis tests are passing, so that's promising.

@ghost

ghost commented Aug 24, 2016

Copy link
Copy Markdown

Thank you for your pull request. As you may know, we require contributors to sign our Contributor License Agreement, and we don't seem to have you on file and listed as active anymore. In order for us to review and merge your code, please email cla@fb.com with your details so we can update your status.

@marpaia

marpaia commented Aug 24, 2016

Copy link
Copy Markdown
Author

I think something is wrong with the CLA. I used to work at Facebook, so my CLA should definitely be on file. This is what I see when I go to the CLA web form:

cla

@fredemmott

Copy link
Copy Markdown

In order for us to review and merge your code, please email cla@fb.com with your details so we can update your status.

We revoke employee CLAs when you become an ex-employee, as you have changed from contributing on behalf of your employer to contributing individually

Comment thread CMakeLists.txt
INCLUDE_DIRECTORIES(${CMAKE_CURRENT_BINARY_DIR})

ADD_LIBRARY(graphqlparser SHARED
ADD_LIBRARY(graphqlparser

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really necessary to build as a different flavor of library for Windows? I think this might break the Python/Go examples.

@marpaia

marpaia commented Sep 10, 2016

Copy link
Copy Markdown
Author

Hey, I switched gears to using https://github.com/graphql-go/graphql. This is a cool project, so I'd love to come back to using it one of these days, but I'm going to close this for now in interest of keeping the PR list clean and if I have a chance to invest time in doing this right, I'll re-open.

@marpaia marpaia closed this Sep 10, 2016
cgrinker added a commit to OffByOneStudios/libgraphqlparser that referenced this pull request May 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants