Own block rules lost after update to v. 1.0.0.3 #381

Activity

1. gorhill commented on Jul 23, 2014

   

   gorhill

   on Jul 23, 2014

   Owner

   More actions

   Crap.

   I just reviewed the code and I can't see why it wouldn't work. Will keep looking but it's kind of too late at this point, there is no way back.

   If you have a back up, restoring should work fine though.
3. gorhill commented on Jul 23, 2014

   

   gorhill

   on Jul 23, 2014

   Owner

   More actions

   Ok so if I understand, before the restore, the block rules were gone, while the allow rules were properly converted to the new storage?
5. gorhill commented on Jul 23, 2014

   

   gorhill

   on Jul 23, 2014

   Owner

   More actions

   Ok. I see potential for a race condition, where there is an attempt to load data before it has been saved. If so, this means that your data was properly converted, but somehow the actual writing of bytes to the storage did not occur before the data was requested.

   I need to fix this.

   The workaround meanwhile in case other users end up with the same problem is a simple restart of the extension (disabling/enabling).
7. gorhill

   closed this as completedin 9502679on Jul 23, 2014
8. gorhill commented on Jul 23, 2014

   

   gorhill

   on Jul 23, 2014

   Owner

   More actions

   Actually, correction:

   The data was irremediably lost. Whichever "block" or "allow" rules was saved first was clobbered if both fields had rules.

   I can still save Opera users I think.