Requests showing up as blocked and allowed in Statistics Request log #242

Activity

1. gorhill commented on Apr 25, 2014

   

   gorhill

   on Apr 25, 2014

   Owner

   More actions

   Hmm good one.

   This is caused by the contentscripthandler.js code which lookup script tags, and test them against matrix filtering only and not ABP filtering. I need to coalesce matrix and ABP filtering in one function so that both filtering paths are properly evaluated (if switched on) from everywhere instead of just in traffic.js:

       // Block request?
       var scopeKey = httpsb.temporaryScopeKeyFromPageURL(pageURL);
       var block = httpsb.evaluateFromScopeKey(scopeKey, type, requestHostname).charAt(0) === 'r';
       var reason;
   
       // Block using ABP filters?
       if ( block === false ) {
           var scope = httpsb.temporaryScopeFromScopeKey(scopeKey);
           if ( scope.abpFiltering === true ) {
               block = httpsb.abpFilters.matchString(requestURL, pageStats.pageDomain, requestHostname);
               if ( block !== false ) {
                   pageStats.abpBlockCount += 1;
                   httpsb.abpBlockCount += 1;
                   reason = 'ABP filter: ' + block;
               }
           }
       }
   
2. gorhill commented on Apr 25, 2014

   

   gorhill

   on Apr 25, 2014

   Owner

   More actions

   Also, something unrelated but highlighted by this bug and that has always bothered me, script tags are reported twice when inline js allowed. I will entered another issue for this: #243.
3. gorhill

   closed this as completedin e7d4545on Apr 25, 2014