Skip to content
This repository was archived by the owner on Nov 15, 2017. It is now read-only.
This repository was archived by the owner on Nov 15, 2017. It is now read-only.

Be able to parse Adblock Plus filter lists to extract and enforce domain rules #149

Closed

Description

@gorhill

HTTPSB could make use of the block-by-domain-name rules in AdBlock Plus: https://adblockplus.org/en/filter-cheatsheet#blocking2.

This, with finding a solution to the import of non-predetermined blacklists (issue #39) would allow user to be even more in control of what to preset-block.

Activity

  1. gorhill commented on Jan 16, 2014

    @gorhill
    OwnerAuthor

    Blocking by address parts and blocking exact addresses should therefore also be supported

    No. Sorry.

    I am not going to make HTTPSB into something I don't intend to make it at this point. Alternative is GPLv3, fork, etc.

    My reason is the core of HTTPSB, I won't overcomplicate it at this point. This piece of code has worked marvelously for both filtering requests and displaying the matrix since pretty much the beginning of HTTPSB. It's fast, performant, logical and most importantly transposes exactly into a matrix UI.

    What you ask above has further complications and I think now I am going to ask for wishes that go to the core of HTTPSB to be completely fleshed out in details, not just on the surface while I am being asked to figure all the difficult issues of UI etc.

    How do you display in the matrix http://example.com/ads/banner123.gif blocked and http://example.com/ads/not-a-banner123.gif not blocked?

    If you want to cast negatively this proposed feature with the expression "halfway" as a way to make me feel bad to not agree, so be it, it is going to be done halfway, I don't plan a for a major core and UI rehaul of HTTPSB to make it into whatever AdBlock does.

    I want this project to keep its fun hobby nature from my POV. Being asked to rewrite everything from the ground up without a clearly defined view of how to keep a clear matrix-based UI at the end, I see this as a chore.

  2. gorhill commented on Jan 22, 2014

    @gorhill
    OwnerAuthor

    I consider this top priority so that I can run comparison benchmarks which could make HTTPSB allow-all/block-exceptionally look better if the Fanboy Ultimate list is used.

  3. added a commit that references this issue on Jan 22, 2014
  4. gorhill commented on Mar 4, 2014

    @gorhill
    OwnerAuthor

    Blocking by address parts and blocking exact addresses should therefore also be supported

    After some experimentations the last two days, I realize this is actually a good idea.

    My apologies for having been so rudely dismissive.

    The idea I am currently entertaining is to keep this as simple as possible though: go through the AdBlock filters only for HTTP requests which are not blocked. And just a checkbox somewhere in the settings on whether the AdBlock rules should also be parsed and enforced. No other UI than this.

    I currently do have a standalone prototype, but given that HTTPSB has already all the framework to read, update, etc ABP files, there are efficiencies to be gained if I move the code from the standalone to HTTPSB. I would leave DOM-modifying rules out though for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions