Skip to content

Use @googlemaps/js-api-loader as a peer dependency #782

Open

Description

@cgarrovillo

@googlemaps/js-api-loader should be used as a peer dependency due to issues like this.

googlemaps/js-api-loader#825

Using this as a dependency expands the blast radius of the dependencies of this package.

Activity

  1. added
    triage meI really want to be triaged.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    on Feb 16, 2024
  2. wangela commented on Feb 16, 2024

    @wangela
    Member

    If you would like to upvote the priority of this issue, please comment below or react on the original post above with 👍 so we can see what is popular when we triage.

    @cgarrovillo Thank you for opening this issue. 🙏
    Please check out these other resources that might help you get to a resolution in the meantime:

    This is an automated message, feel free to ignore.

  3. IsraelVazquezEsparza commented on Feb 16, 2024

    @IsraelVazquezEsparza

    @cgarrovillo Thanks. It works!

  4. added
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    and removed
    triage meI really want to be triaged.
    on Feb 16, 2024
  5. usefulthink commented on Feb 23, 2024

    @usefulthink
    Contributor

    I don't think that would have helped much, and most of the time - when dependencies aren't broken - it would only make it more complicated to install this package.

    What happened last week was a published version of @googlemaps/js-api-loader that was broken. That would have had mostly the same effect if it was installed as a peer-dependency instead of a transitive dependency.

    The only thing you can do in such a situation is to pin the dependency to an older version, and that can be done for both peerDependencies as well as for transitive dependencies (by specifying a resolution for the package in the package.json).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions