Skip to content

Info log output in version 4.7.1 #461

Open

Description

@vsemionov

#455 changed the queries_quota output from print() to logging (see #451). However, since this library is initialized when our Django application is initialized, the same irrelevant output is scattered in multiple places, like management command output, daily maintenance tasks, report emails, etc. Can we please change this to level DEBUG, so it's hidden by default?

Activity

  1. added
    triage meI really want to be triaged.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    on Dec 7, 2022
  2. wangela commented on Jan 26, 2023

    @wangela
    Member

    Sounds reasonable. Feel free to send a pull request with your desired fix.

  3. stianjensen commented on Feb 13, 2024

    @stianjensen

    A pull request has been made, can we also get it reviewed and hopefully a fix released soon?

  4. stianjensen commented on Apr 2, 2024

    @stianjensen

    @wangela Would you able to take a look at the proposed PR with a fix?

  5. sondrelg commented on Apr 2, 2024

    @sondrelg
    Contributor

    In the meantime, fyi, you can also configure the log level for the package in your django application. Setting the handler log level should fix your issue:

    LOGGING = {
        "version": 1,
        "disable_existing_loggers": False,
        "handlers": {
            "console": {
                "class": "logging.StreamHandler",
            },
        },
        "google_maps_services_python": {
            ...,
            "level": "WARNING",
        },
    }
  6. vsemionov commented on Apr 2, 2024

    @vsemionov
    Author

    @sondrelg @wangela That's true, but it would also hide any future messages with an info level, and is not optimal. This issue's pull request is a trivial one-line change and has been open since 2022. I don't understand why it's such a problem to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

triage meI really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions