Repository navigation
feat: Add "transfer_manager" module for concurrent uploads and downloads as a preview feature - #844
Conversation
andrewsg
added
the
do not merge
product-auto-label
Bot
added
size: l
|
Docstrings pending initial review |
andrewsg
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
cojenco
left a comment
cojenco
left a comment
There was a problem hiding this comment.
Couple questions, generally looking really good!
This is probably in the planning, but it'd be very helpful to add method and parameter descriptions in the docstring for the new module.
| return results | ||
|
|
||
|
|
||
| def download_chunks_concurrently_to_file( |
There was a problem hiding this comment.
What is the guidance on when a customer should rely on download_chunks_conccurrently_to_file directly vs. not?
There was a problem hiding this comment.
Good question! The benefit is that it adds speed for large files in cases where one thread can't saturate the network bandwidth. And the drawback is that it's much more complex, and adds overhead esp. if chunk size is low. How to distill that into customer guidance? I'll have to think about it.
frankyn
left a comment
frankyn
left a comment
There was a problem hiding this comment.
Two comments; overall LGTM,
cojenco
left a comment
cojenco
left a comment
There was a problem hiding this comment.
A few questions, thanks for the thorough tests!
|
Great to see this, starting a new project that needs exactly this functionality. Thanks. |
andrewsg
removed
the
do not merge
andrewsg
changed the title
product-auto-label
Bot
added
size: xl
This module adds support for concurrent uploads and downloads of multiple files, and concurrent chunked downloads of a single file.
Transfer Manager is currently a preview feature. The API and behavior of the module may change depending on user feedback. Please freely let us know about your experiences with the feature (be they problems, suggestions, or general feedback) by opening an issue on Github or commenting on an existing issue on the topic.
Fixes #36 and #388 🦕