Update conformance tests to fit the new format #92

Activity

1. IlyaFaer

   added

   api: storageIssues related to the googleapis/python-storage API.Issues related to the googleapis/python-storage API.

   testing

   on Mar 31, 2020
2. IlyaFaer

   self-assigned this

   on Mar 31, 2020
3. yoshi-automation

   added

   triage meI really want to be triaged.I really want to be triaged.

   on Apr 1, 2020
4. IlyaFaer

   added

   type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.

   and removed

   triage meI really want to be triaged.I really want to be triaged.

   on Apr 1, 2020
5. IlyaFaer commented on Apr 2, 2020

   

   IlyaFaer

   on Apr 2, 2020

   Author

   More actions

   @frankyn, in signingV4Tests we have expiration as str:
   https://github.com/googleapis/conformance-tests/blob/24a5e2373d1240ff3538f9999888053ba8b6a539/storage/v1/v4_signatures.json#L8

   But in postPolicyV4Tests it is int:
   https://github.com/googleapis/conformance-tests/blob/24a5e2373d1240ff3538f9999888053ba8b6a539/storage/v1/v4_signatures.json#L281

   Should we bring this to a single type?
6. frankyn

   closed this as completedin #96on Apr 2, 2020
7. frankyn commented on Apr 2, 2020

   

   frankyn

   on Apr 2, 2020

   Contributor

   More actions

   I just saw this question.

   Yes, bring it in as an int. I'm surprised we didnt' catch that during the signed URLs or Post Policies.