Storage: Expose the get method of Notifications #68

Activity

1. product-auto-label

   added

   api: storageIssues related to the googleapis/python-storage API.Issues related to the googleapis/python-storage API.

   on Feb 20, 2020
2. HemangChothani

   self-assigned this

   on Feb 20, 2020
3. HemangChothani

   added

   type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.

   on Feb 20, 2020
4. HemangChothani commented on Feb 20, 2020

   

   HemangChothani

   on Feb 20, 2020

   ContributorAuthor

   More actions

   Closing this Feature request as found reload method work as get notification.
5. HemangChothani

   closed this as completedon Feb 20, 2020
6. HemangChothani

   reopened this on Feb 20, 2020
7. HemangChothani commented on Feb 20, 2020

   

   HemangChothani

   on Feb 20, 2020

   ContributorAuthor

   More actions

   @frankyn @crwilcox Need a suggestion.
   Is it ok to expose a method which get a notification from notificationId?

   Method:
   bucket.get_notification(notification_id)
8. frankyn commented on Feb 20, 2020

   

   frankyn

   on Feb 20, 2020

   Last edited by frankyn

   Contributor

   More actions

   Yes, this is an issue with usability with get_notification, in which get by Id is not available.

   The changes should be minimal to the existing surface by making:

   bucket.notification(): make topic_name optional and surface notification_id.

   notification = bucket.notification(id="notification-id")
   notification.reload()
   
   # Potentially
   notification_with_metadata = bucket.get_notification(id="notification-id")
9. frankyn commented on Feb 20, 2020

   

   frankyn

   on Feb 20, 2020

   Contributor

   More actions

   Updated comment with potential examples.

   Note: please prioritize v4 signature requests that haven't started:
   https://github.com/googleapis/python-storage/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+v4
10. frankyn

    closed this as completedin #77on Mar 6, 2020